Date: Fri, 29 Aug 2008 16:09:33 +0800 (CST) From: Sunpoet Po-Chuan Hsieh <sunpoet@sunpoet.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/126935: [PATCH] archivers/lzo2: fix build for users not using /bin/sh as root's shell Message-ID: <20080829080933.11BAF1E44@sunpoet.net> Resent-Message-ID: <200808290810.m7T8A3wB022299@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 126935
>Category: ports
>Synopsis: [PATCH] archivers/lzo2: fix build for users not using /bin/sh as root's shell
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Fri Aug 29 08:10:03 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Sunpoet Po-Chuan Hsieh
>Release: FreeBSD 7.0-STABLE amd64
>Organization:
SUNPOET.net
>Environment:
System: FreeBSD bonjour.sunpoet.net 7.0-STABLE FreeBSD 7.0-STABLE #10: Fri Aug 1 11:36:08 CST 2008 root@bonjour.sunpoet.net:/usr/obj/usr/src/sys/bonjour amd64
>Description:
The newly-added -x arguemnt is for sh.
Instead of $SHELL, use $SH to call /bin/sh explicitly.
It fixes build for users not using /bin/sh as root's shell.
For me, I use /bin/tcsh as root's shell.
===> Running self-tests for lzo2-2.03_2 (can take a few minutes, without output)
cd /usr/ports/works/usr/ports/archivers/lzo2/work/lzo-2.03 && make test SHELL="/bin/tcsh -x"
make all-recursive
Making all in include
Making all in lzo
Making all in src
Making all in lzotest
Making all in examples
Making all in tests
Making all in minilzo
./lzotest/lzotest -mavail -n10 -q ./COPYING
/bin/tcsh -x -e ./util/check.sh .
set -e
set: Variable name must begin with a letter.
*** Error code 1
Stop in /usr/ports/works/usr/ports/archivers/lzo2/work/lzo-2.03.
*** Error code 1
Stop in /usr/ports/archivers/lzo2.
>How-To-Repeat:
>Fix:
--- /usr/ports/archivers/lzo2/Makefile.orig 2008-08-29 13:52:49.176177000 +0800
+++ /usr/ports/archivers/lzo2/Makefile 2008-08-29 15:50:15.774828146 +0800
@@ -25,7 +25,7 @@
post-build:
@${ECHO_MSG} "===> Running self-tests for ${PKGNAME} (can take a few minutes, without output)"
- cd ${WRKSRC} && ${MAKE} test SHELL="${SHELL} -x"
+ cd ${WRKSRC} && ${MAKE} test SHELL="${SH} -x"
post-install:
.if !defined(NOPORTDOCS)
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080829080933.11BAF1E44>