Date: Wed, 14 Sep 2016 10:52:45 +0200 From: Michael Reifenberger <mike@reifenberger.com> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r422061 - in head/comms/uhd: . files Message-ID: <20160914105245.Horde.cp5oX9evYBLUL3LRGKjxK-b@mail.eeeit.de> In-Reply-To: <2fc3d1fd-f23a-e895-6595-f2cfda0967ff@FreeBSD.org> References: <201609131858.u8DIwelq007807@repo.freebsd.org> <2fc3d1fd-f23a-e895-6595-f2cfda0967ff@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
first a big thanks for your hints and suggestions!
Zitat von Mathieu Arnold <mat@freebsd.org>:
> Le 13/09/2016 à 20:58, Michael Reifenberger a écrit :
>> +EXTRACT_ONLY= ${DISTFILES}
>
> That is not needed, it is the default.
>
>> +GH_TAGNAME= ${UHD_COMMIT}
>> +
>> +UHD_COMMIT= 32951af2f3e7b1ddb56486c9f15b2e1033605bd6
>
Merged.
> I'm not sure using a second variable only once is needed.
>
>> +COMPILER_FEATURES= libc++
>
Deleted.
> That variable is *read-only*, writing to it makes no sense.
>
>> +MAKE_JOBS_UNSAFE= yes
>
Deleted. Seems to be unnecessary.
> When adding MAKE_JOBS_UNSAFE, you have to say why it does not build with
> make -j.
>
>> +DOCSDIR= share/doc/uhd
>
> This is the default and not needed.
>
>> +.if ${OSVERSION} < 800000
>> +IGNORE= needs libusb 1.0
>> +.endif
>
> Adding that OSVERSION check makes no sense, no release before 9 will
> work with the current ports tree.
>
Deleted.
>> +.if ${PORT_OPTIONS:MDOCS}
>> +BUILD_DEPENDS+= doxygen:${PORTSDIR}/devel/doxygen
>> +CMAKE_ARGS+= -DENABLE_DOXYGEN:STRING="ON"
>> +HAVEDOCS= YES
>> +.endif
>
> Do not add doxygen as a dependency with a DOCS option, use a DOXYGEN one.
>
You mean like this:
.if ${PORT_OPTIONS:MDOXYGEN}
...
.endif
>> +- DESTINATION ${LIBRARY_DIR}/pkgconfig
>> ++ DESTINATION libdata/pkgconfig
>
> This is handled by USES=pathfix.
>
Done.
>
> --
> Mathieu Arnold
Again, thanks alot for your tips!
Greetings
---
mike
Gruß
---
Michael Reifenberger
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160914105245.Horde.cp5oX9evYBLUL3LRGKjxK-b>