From owner-cvs-all@FreeBSD.ORG Wed Sep 6 20:15:44 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8354816A4DE; Wed, 6 Sep 2006 20:15:44 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3EF4143D46; Wed, 6 Sep 2006 20:15:44 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k86KFiKP052692; Wed, 6 Sep 2006 20:15:44 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k86KFird052691; Wed, 6 Sep 2006 20:15:44 GMT (envelope-from ru) Message-Id: <200609062015.k86KFird052691@repoman.freebsd.org> From: Ruslan Ermilov Date: Wed, 6 Sep 2006 20:15:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sbin/sysctl sysctl.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2006 20:15:44 -0000 ru 2006-09-06 20:15:43 UTC FreeBSD src repository Modified files: sbin/sysctl sysctl.c Log: While convenient, avoid using alloca() for reasons specified in the BUGS section of the alloca(3) manpage. In particular, when the number of TCP sockets is several tens of thousand, trying to "sysctl -a" would SIGSEGV on the net.inet.tcp.pcblist entry (it would exceed the stacksize ulimit, in an undetectable manner). Reported by: Igor Sysoev Revision Changes Path 1.75 +20 -4 src/sbin/sysctl/sysctl.c