From owner-svn-ports-head@FreeBSD.ORG  Thu Dec  6 14:15:53 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 3F7B89C1;
 Thu,  6 Dec 2012 14:15:53 +0000 (UTC)
 (envelope-from r.c.ladan@gmail.com)
Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com
 [209.85.217.182])
 by mx1.freebsd.org (Postfix) with ESMTP id 1015B8FC08;
 Thu,  6 Dec 2012 14:15:51 +0000 (UTC)
Received: by mail-lb0-f182.google.com with SMTP id go10so6786673lbb.13
 for <multiple recipients>; Thu, 06 Dec 2012 06:15:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject
 :references:in-reply-to:x-enigmail-version:content-type
 :content-transfer-encoding;
 bh=R4OeeHrVT9e8qoJFcFhfM4UJspTVmFqsoDSPKcZqGWo=;
 b=XBDdg5Fr67C7l6tS15W+EtyY7gcaTolNFo85xVfYbBWpj6tOPtUlgUdEBqFujXWhYN
 zLynten3Oh9PuYzlJeBqoKRLyZ6deoa8s7Zb+Qge29IAX5wW0QzT4PB68JlGu1W0rb+W
 qIEfgEbIib+MekEwPsaH3OQcC6knHnBdIwREA5Y4zrEM9RPZwmIq7AZdhoGxA6jCG1eB
 /Vi80Fa1CE5cIa/3wgh8N+8conE8MeiN/eA5OAbqLSORt7jWjzP9b6fcZXQfOtA9YsvI
 ZKVQTFEox4MzIBDwyb81iy9RirNhNDk52mTKNbh8Vcjvl+KcwHrrT6rM5ASmyWSZIvR7
 wU5Q==
Received: by 10.152.47.75 with SMTP id b11mr1784689lan.14.1354803350948;
 Thu, 06 Dec 2012 06:15:50 -0800 (PST)
Received: from ?IPv6:2001:980:d7ed:1:25bd:1557:3a17:6842?
 ([2001:980:d7ed:1:25bd:1557:3a17:6842])
 by mx.google.com with ESMTPS id ti4sm3488568lab.1.2012.12.06.06.15.48
 (version=SSLv3 cipher=OTHER); Thu, 06 Dec 2012 06:15:49 -0800 (PST)
Sender: =?UTF-8?Q?Ren=C3=A9_Ladan?= <r.c.ladan@gmail.com>
Message-ID: <50C0A893.2020604@freebsd.org>
Date: Thu, 06 Dec 2012 15:15:47 +0100
From: =?UTF-8?B?UmVuw6kgTGFkYW4=?= <rene@freebsd.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r308378 - head/science/kst
References: <201212061028.qB6ASSZH019689@svn.freebsd.org>
 <20121206140607.GA40049@FreeBSD.org>
In-Reply-To: <20121206140607.GA40049@FreeBSD.org>
X-Enigmail-Version: 1.4.6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Dec 2012 14:15:53 -0000

On 06-12-2012 15:06, Alexey Dokuchaev wrote:
> On Thu, Dec 06, 2012 at 10:28:28AM +0000, Rene Ladan wrote:
>> New Revision: 308378
>> URL: http://svnweb.freebsd.org/changeset/ports/308378
>>
>> +# Created by:	Markus Brueffer <markus@FreeBSD.org>
> 
> Please use space, not tab here.
> 
OK, fixed.

>> +OPTIONS_DEFINE=	NETCDF CDF KDEBASE
>> +CDF_DESC=	CDF data support
>> +KDEBASE=	JavaScript console
> 
> Shouldn't it read KDEBASE_DESC?  Also I fail to see how KDEBASE describes
> JavaScript console.
>
Yes, my mistake.  I think it is because the KDEBASE option pulls in
libkonsolepart.so which might provide a console, but KDE people probably
know the fine details (I was just converting the port to optionsNG).

René