From owner-freebsd-ports@FreeBSD.ORG Tue May 20 06:55:30 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D370837B401 for ; Tue, 20 May 2003 06:55:30 -0700 (PDT) Received: from biocandy.borg.cx (h108n2fls31o270.telia.com [217.208.199.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id B823243F75 for ; Tue, 20 May 2003 06:55:28 -0700 (PDT) (envelope-from fredde@borg.cx) Received: from biocandy.borg.cx (localhost [127.0.0.1]) by biocandy.borg.cx (8.12.6/8.12.6) with ESMTP id h4KDtQYU010852 for ; Tue, 20 May 2003 15:55:26 +0200 (CEST) (envelope-from fredde@borg.cx) Received: (from fredde@localhost) by biocandy.borg.cx (8.12.6/8.12.6/Submit) id h4KDtNTu010851 for ports@FreeBSD.org; Tue, 20 May 2003 15:55:23 +0200 (CEST) X-Authentication-Warning: biocandy.borg.cx: fredde set sender to fredde@borg.cx using -f Date: Tue, 20 May 2003 15:55:23 +0200 From: Fredrik Lindberg To: ports@FreeBSD.org Message-ID: <20030520135523.GA3465@borg.cx> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="a8Wt8u1KmwUX3Y2C" Content-Disposition: inline User-Agent: Mutt/1.4.1i Subject: yafc 1.0 port patch which fixes segfault X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 May 2003 13:55:31 -0000 --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I've sent this mail to ports@freebsd.org because that is the email-address which is setup as maintainer for this port. If this is wrong, please forward this email to the right maintainer, thanks. To whom it might concern, There is an annoying bug present in yafc 1.0, as far as I could tell the author is aware of the bug and (probably) knows how to fix it but no new release has been made (at least not prior to today, 2003-05-20). The bug is very silly but causes yafc to segfault if you try to upload/download a file which already is present on the target system. yafc borg:/> put dump/foobar /usr/home/fredde/dump/foobar yafc borg:/> put dump/foobar Segmentation fault (core dumped) To get to the point. I've attatched a patch which fixes this problem. Perhaps somebody could include the patch in the yafc-1.0 port until the next release of yafc. Regards, Fredrik --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="yafc.patch" Common subdirectories: yafc-1.0.orig/src/ftp and yafc-1.0/src/ftp diff -u yafc-1.0.orig/src/get.c yafc-1.0/src/get.c --- yafc-1.0.orig/src/get.c Tue May 20 15:22:28 2003 +++ yafc-1.0/src/get.c Tue May 20 15:22:58 2003 @@ -279,7 +279,7 @@ e = xstrdup(ctime(&sb.st_mtime)); a = ask(ASKYES|ASKNO|ASKUNIQUE|ASKCANCEL|ASKALL|ASKRESUME, ASKRESUME, - _("Local file '%s' exists\nLocal: %ld bytes, %sRemote: %ld bytes, %sOverwrite?"), + _("Local file '%s' exists\nLocal: %lld bytes, %sRemote: %ld bytes, %sOverwrite?"), shortpath(dest, 42, gvLocalHomeDir), sb.st_size, e ? e : "unknown date", ftp_filesize(fi->path), ctime(&ft)); Common subdirectories: yafc-1.0.orig/src/libmhe and yafc-1.0/src/libmhe diff -u yafc-1.0.orig/src/put.c yafc-1.0/src/put.c --- yafc-1.0.orig/src/put.c Tue May 20 15:22:29 2003 +++ yafc-1.0/src/put.c Tue May 20 15:23:08 2003 @@ -217,7 +217,7 @@ e = xstrdup(ctime(&sb->st_mtime)); a = ask(ASKYES|ASKNO|ASKUNIQUE|ASKCANCEL|ASKALL|ASKRESUME, ASKRESUME, - _("Remote file '%s' exists\nLocal: %ld bytes, %sRemote: %ld bytes, %sOverwrite?"), + _("Remote file '%s' exists\nLocal: %lld bytes, %sRemote: %ld bytes, %sOverwrite?"), shortpath(dest, 42, ftp->homedir), sb->st_size, e ? e : "unknown date", ftp_filesize(f->path), ctime(&ft)); --a8Wt8u1KmwUX3Y2C--