From owner-svn-ports-all@FreeBSD.ORG  Sun Dec 28 10:02:47 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5BF5DF71;
 Sun, 28 Dec 2014 10:02:47 +0000 (UTC)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DBCDE667AD;
 Sun, 28 Dec 2014 10:01:49 +0000 (UTC)
Received: from [172.16.129.21] (unknown [110.5.105.104])
 by ainaz.pair.com (Postfix) with ESMTPSA id 305123F47D;
 Sun, 28 Dec 2014 05:01:44 -0500 (EST)
Date: Sun, 28 Dec 2014 11:01:30 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Kubilay Kocak <koobs@FreeBSD.org>
Subject: Re: svn commit: r375696 - head/multimedia/libx264
In-Reply-To: <201412280459.sBS4xbU9021196@svn.freebsd.org>
Message-ID: <alpine.LSU.2.11.1412281100080.3428@tuna.site>
References: <201412280459.sBS4xbU9021196@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Dec 2014 10:02:47 -0000

On Sunday 2014-12-28 04:59, Kubilay Kocak wrote:
> Log:
>   multimedia/libx264: Fix PGO/GCC options
>   
>   - Revert options helpers for PGO and GCC .. *shakes fist*. We end up
>     setting USE_GCC=yes yes otherwise, and that's not valid.
>   - libx264 and x264 share the same distfiles, use the same DIST_SUBDIR

> +.if ${PORT_OPTIONS:MGCC}
> +USE_GCC=	yes
> +.elif ${PORT_OPTIONS:MPGO}
> +USE_GCC=	any
> +.endif

Why not USE_GCC=yes in either case?

Using anything like the old version of GCC in base (GCC 4.2) for
anyone asking for PGO feels just, hmm, odd.  Plus it complicates
the testing matrix.

Gerald