From owner-freebsd-net@FreeBSD.ORG Sat Jan 8 02:16:36 2011 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D1F0C106564A for ; Sat, 8 Jan 2011 02:16:36 +0000 (UTC) (envelope-from spawk@acm.poly.edu) Received: from acm.poly.edu (acm.poly.edu [128.238.9.200]) by mx1.freebsd.org (Postfix) with ESMTP id 6EDFC8FC15 for ; Sat, 8 Jan 2011 02:16:36 +0000 (UTC) Received: (qmail 12365 invoked from network); 8 Jan 2011 02:16:35 -0000 Received: from unknown (HELO ?192.168.0.2?) (spawk@96.224.221.101) by acm.poly.edu with CAMELLIA256-SHA encrypted SMTP; 8 Jan 2011 02:16:35 -0000 Message-ID: <4D27C8F6.9030803@acm.poly.edu> Date: Fri, 07 Jan 2011 21:16:22 -0500 From: Boris Kochergin User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.12) Gecko/20101031 Thunderbird/3.1.6 MIME-Version: 1.0 To: Doug Barton References: <4D27AF1D.2030505@acm.poly.edu> <4D27C55D.8070200@acm.poly.edu> <4D27C73E.8040907@FreeBSD.org> In-Reply-To: <4D27C73E.8040907@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org, Sergey Kandaurov , delphij@FreeBSD.org Subject: Re: NDP Ethernet address display X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jan 2011 02:16:36 -0000 On 01/07/11 21:09, Doug Barton wrote: > On 01/07/2011 18:01, Boris Kochergin wrote: > >>>> - snprintf(hbuf, sizeof(hbuf), "%x:%x:%x:%x:%x:%x", > > There are numerous examples of this string in the tree. Some of them > seem like they may be correct, but many of them are obviously printing > out mac addresses and should be converted, one way or another: > > http://dougbarton.us/mac-padding.txt > > In any case, thanks to Xin for fixing this one so quickly. :) > > > Doug > The sscanf() calls are definitely fine. I made sure to test that bit in ndp(8). Thanks, Xin! -Boris