From owner-freebsd-current@FreeBSD.ORG  Wed Dec 27 23:16:25 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 63AAB16A407
	for <current@freebsd.org>; Wed, 27 Dec 2006 23:16:25 +0000 (UTC)
	(envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.freebsd.org (Postfix) with ESMTP id 3D4A413C480
	for <current@freebsd.org>; Wed, 27 Dec 2006 23:16:25 +0000 (UTC)
	(envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.11/8.13.6) with ESMTP id kBRMpRef067418;
	Wed, 27 Dec 2006 14:51:27 -0800 (PST)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.11/8.12.3/Submit) id kBRMpRQj067417;
	Wed, 27 Dec 2006 14:51:27 -0800 (PST) (envelope-from rizzo)
Date: Wed, 27 Dec 2006 14:51:27 -0800
From: Luigi Rizzo <rizzo@icir.org>
To: current@freebsd.org
Message-ID: <20061227145127.B67280@xorpc.icir.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
Cc: 
Subject: sys/dev/usb/usbdi_util.h not protected from multiple includes ?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Dec 2006 23:16:25 -0000

Just noticed (on stable while building a kernel module, but this
affects current as well) that  sys/dev/usb/usbdi_util.h is
not protected from multiple includes - i.e. it doesn't have
the

	#ifndef _USBDI_UTIL_H
	#define _USBDI_UTIL_H
	...
	#endif

wrapper around it.
Any objection if i commit it ?

	cheers
	luigi