From owner-cvs-src@FreeBSD.ORG Mon Mar 22 12:47:26 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0560D16A4CE for ; Mon, 22 Mar 2004 12:47:26 -0800 (PST) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id C0F3C43D53 for ; Mon, 22 Mar 2004 12:47:25 -0800 (PST) (envelope-from nate@root.org) Received: (qmail 34481 invoked by uid 1000); 22 Mar 2004 20:47:26 -0000 Date: Mon, 22 Mar 2004 12:47:26 -0800 (PST) From: Nate Lawson To: Scott Long In-Reply-To: <20040322134700.G30715@pooker.samsco.home> Message-ID: <20040322124531.P34428@root.org> References: <200403222039.i2MKdKcq049699@repoman.freebsd.org> <20040322134700.G30715@pooker.samsco.home> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pcib.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2004 20:47:26 -0000 On Mon, 22 Mar 2004, Scott Long wrote: > On Mon, 22 Mar 2004, Nate Lawson wrote: > > njl 2004/03/22 12:39:20 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/acpica acpi_pcib.c > > Log: > > Use the correct length for appending an extended irq resource. This may > > have broken APIC routing. This bug has been present since rev 1.33. > > Ouch! Is there any indication of what this might look like to people with > affected systems? Using a different interrupt than the link device suggests? I'm not sure. It may not have been visible since we only take the first interrupt currently and min(sizeof(irq), sizeof(extended_irq)) is large enough to cover at least one, I believe. In any case, the fix is correct and might possibly help. -Nate