From owner-cvs-src@FreeBSD.ORG  Mon Mar 21 16:51:46 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3898D16A4CE; Mon, 21 Mar 2005 16:51:46 +0000 (GMT)
Received: from rosebud.otenet.gr (rosebud.otenet.gr [195.170.0.26])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4CB3A43D48; Mon, 21 Mar 2005 16:51:45 +0000 (GMT)
	(envelope-from keramida@freebsd.org)
Received: from orion.daedalusnetworks.priv (aris.bedc.ondsl.gr
	[62.103.39.226])j2LGpC1m017784;	Mon, 21 Mar 2005 18:51:12 +0200
Received: from orion.daedalusnetworks.priv (orion [127.0.0.1])
	j2LGph2V003893;	Mon, 21 Mar 2005 18:51:43 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Received: (from keramida@localhost)j2LGphfl003892;
	Mon, 21 Mar 2005 18:51:43 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Date: Mon, 21 Mar 2005 18:51:43 +0200
From: Giorgos Keramidas <keramida@freebsd.org>
To: src-committers@freebsd.org, cvs-src@freebsd.org,
	cvs-all@freebsd.org
Message-ID: <20050321165143.GA3842@orion.daedalusnetworks.priv>
References: <200503211636.j2LGa5Xx054701@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200503211636.j2LGa5Xx054701@repoman.freebsd.org>
Subject: Re: cvs commit: src/usr.sbin/pstat Makefile pstat.8 pstat.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Mar 2005 16:51:46 -0000

On 2005-03-21 16:36, Giorgos Keramidas <keramida@freebsd.org> wrote:
>   Revision  Changes    Path
>   1.13      +2 -2      src/usr.sbin/pstat/Makefile
>   1.47      +8 -3      src/usr.sbin/pstat/pstat.8
>   1.93      +40 -19    src/usr.sbin/pstat/pstat.c

This is still WARNS=2 clean, as the previous pstat version.

The following change makes pstat WARNS=3 clean in i386, sparc64 and
amd64.  Are we allowed to use C99 constructs like the ones shown below
in userlevel code?

%%%
Index: pstat.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/pstat/pstat.c,v
retrieving revision 1.93
diff -u -r1.93 pstat.c
--- pstat.c	21 Mar 2005 16:36:05 -0000	1.93
+++ pstat.c	21 Mar 2005 16:42:45 -0000
@@ -81,11 +81,11 @@
 };
 
 static struct nlist nl[] = {
-	{ "_constty", 0 },
-	{ "_maxfiles", 0 },
-	{ "_nfiles", 0 },
-	{ "_tty_list", 0 },
-	{ "" }
+	{ .n_name = "_constty" },
+	{ .n_name = "_maxfiles" },
+	{ .n_name = "_nfiles" },
+	{ .n_name = "_tty_list" },
+	{ .n_name = "" }
 };
 
 static int	humanflag;
%%%