From owner-svn-ports-all@FreeBSD.ORG Sun Aug 19 21:41:26 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 38002106566B for ; Sun, 19 Aug 2012 21:41:26 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id B49028FC0A for ; Sun, 19 Aug 2012 21:41:25 +0000 (UTC) Received: by wgbds11 with SMTP id ds11so4775027wgb.31 for ; Sun, 19 Aug 2012 14:41:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=23TYkysD/pIsBc94+EXLPMjvhIQ/tPu24J4bSYwB2w0=; b=dSyddHZpLDvxbHX8qX02PcizWmkcVkUFvYtM9+U3A7vKEC6+FuyZS9EhfSIX/wZx3x +l8O31Je+Kp8yjQ2NMT7xgrFTAyfl9j1azUSRBrdVbFGnXCK5lQHUbfpRN4q8zQnT3O9 H1LiFDVGWdtdlrEVslBmfqsLR1Rqumv0UOWqvZQJt1uoTtgJPfdSPzNT4IY3uuv0JnrC xyK5VmsLFA9fF7hYnMVsjZG+t/8N737lPNODscK0VnKIEf0PtOVJ5m/LbNv05VXXcMU3 nH5kDPxEZOES8ohS0oOg07MRwTpj6LKK+kXCxgqhSCLjrCOOgG7sFI6TQeAZwNRFwNf+ soYw== MIME-Version: 1.0 Received: by 10.180.78.135 with SMTP id b7mr23287941wix.11.1345412484583; Sun, 19 Aug 2012 14:41:24 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.194.16.138 with HTTP; Sun, 19 Aug 2012 14:41:24 -0700 (PDT) In-Reply-To: <201208191707.q7JH7tZ8011378@svn.freebsd.org> References: <201208191707.q7JH7tZ8011378@svn.freebsd.org> Date: Sun, 19 Aug 2012 14:41:24 -0700 X-Google-Sender-Auth: 1xNZxom9Ur2RpFs5N3Xe5xhNvzs Message-ID: From: Jason Helfman To: Guido Falsi X-Gm-Message-State: ALoCoQmu3YgblKJrwu2fQ7gZtswuHZg0G060XA0toiI6psGi00G/oQNbZizN/cRKLeJd610rcWSk Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r302766 - head/games/moagg X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2012 21:41:26 -0000 On Sun, Aug 19, 2012 at 10:07 AM, Guido Falsi wrote: > Author: madpilot > Date: Sun Aug 19 17:07:55 2012 > New Revision: 302766 > URL: http://svn.freebsd.org/changeset/ports/302766 > > Log: > - Remove own OPTION "DATA" > - Honour NOPORTDATA instead of own option > > PR: ports/170736 > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=170736 > Submitted by: nemysis (maintainer) > Approved by: crees, tabthorpe (mentors, implicit) > > Modified: > head/games/moagg/Makefile > > Modified: head/games/moagg/Makefile > > ============================================================================== > --- head/games/moagg/Makefile Sun Aug 19 17:02:42 2012 (r302765) > +++ head/games/moagg/Makefile Sun Aug 19 17:07:55 2012 (r302766) > @@ -20,9 +20,6 @@ COMMENT= Pilot a small space ship > > LICENSE= GPLv2 > > -OPTIONS_DEFINE= DATA > -OPTIONS_DEFAULT= DATA > - > USE_ZIP= yes > USE_JAVA= yes > JAVA_VERSION= 1.5+ > @@ -47,7 +44,7 @@ do-install: > ${INSTALL_SCRIPT} ${WRKSRC}/run.sh.new ${PREFIX}/bin/${PORTNAME} > > # Data > -.if ${PORT_OPTIONS:MDATA} > +.if !defined (NOPORTDATA) > ${MKDIR} ${DATADIR} > @(cd ${WRKSRC} && ${COPYTREE_SHARE} "data ghosts jar" ${DATADIR}) > . for d in hiscores.dat log4j.properties > > If it always requires DATA, per pr, why is there a check? Shouldn't DATA be installed without a check, and not honor NOPORTDATA? -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh