From nobody Sun Feb 8 10:20:09 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f83jp0ZM4z6RWFd; Sun, 08 Feb 2026 10:20:14 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f83jn6MH8z400V; Sun, 08 Feb 2026 10:20:13 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770546013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=854l7yE6GT+30IyMnbimeuAliHvnMLTzWF0blMtYPTM=; b=C9n2XxFkSlbpA6mGvzAysZSkSB8JGO2dEye23/qV6RXEWc9TRK3iFs4PCb2qgB2AvpLOt8 ncJ4o1w4vzirXKXzuMlwerVuSpTnMx2fZOqNYlG5hBjDyVyU6D7Vyds0mq9d2TaNKSmgWi 6xWqBQFA6YEB/CdtdCrhlMLickve1iDIy78dScO3asvqV1krz7MnTRkI/6zCb7nNVF7eFE splFcDyFF+8zYoCM+G4hXXwtO56CTun0/KCH5PymNZDUskI9KRS7JhiJfaN2DVX6U0v+wm TrTAT32BExNOhCq4Silz8OOsuBDqFfrgrBG1Dqtxkp6suhyHKk1CcsbZ9gSZug== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770546013; a=rsa-sha256; cv=none; b=MhX/S8WBES62ukXdfdsIUT4d4m9sDnhV1ynosNpM+XpfZwUMv9DK/GzuWnTb8BMHJ88idA UZQ7jXxqDMYcFK4Nkxin9h6sBjdAFc14VEVficJ6MmbCUy3vW6lbdY7WKQRacJCdSTTH69 OHm9GOdiqOoAe/YZCMbhOPEeV9derYEizPjqK3PKATVxc1sOOhMSvn6bR5t7mN5WFuq65b QWrwWPvszh60Xh9CbporuKgNfOVKPiDVa0DN5uuLM26XiyXtW70i0mIX/qObSz/mTIgYnB b9uKrLMXsIXYK2++RBEszAOmnUH1gNGYMteCnfJ6uUFLQeTS8oHTOjVMufrM+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770546013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=854l7yE6GT+30IyMnbimeuAliHvnMLTzWF0blMtYPTM=; b=W9RpT9mY9TdHKXDZWFqb4qrPuxA7dkQH0u4ojbB1cfM3/mGiY5VOPHmxKDkOSZeiPZ0w2y bs2meqk8bqqfX/m/k8+hZVxvulT3Azoy1s9Q0EWd5BQ3Elrlf4+/XBLEgOr0zfIKCfQ4lP +BUBrlImS9KuX7OO4fuRr23Fj+zu3hfYtQZeizabpQWNUOfehKqukqOAPBMetil5Ch3ShS QchcSaSfZwEb728pH5f7QtFO/TwTSd4r+omtze/RkxNaJbKu2Aimzw/iSKlUeBIhpm/swM Oaxntqz+GoDVPZruzH802lM+5jsioRkveSP4KhSBz3N30dMG0VenAgnnr6e1uw== Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1101:be00:614d:4071:7145:c2c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: tuexen) by smtp.freebsd.org (Postfix) with ESMTPSA id 4f83jm4hvszHSh; Sun, 08 Feb 2026 10:20:12 +0000 (UTC) (envelope-from tuexen@FreeBSD.org) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\)) Subject: Re: git: 7b6e84c9ac56 - main - ure: improve checksum offloading From: Michael Tuexen In-Reply-To: <2926D3E0-F01A-4D6E-BCE7-6AB370054D67@FreeBSD.org> Date: Sun, 8 Feb 2026 11:20:09 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <697ddd34.3ef70.43e05480@gitrepo.freebsd.org> <98155039-1cb4-4420-a66e-1b6bd94464c8@freebsd.org> <2926D3E0-F01A-4D6E-BCE7-6AB370054D67@FreeBSD.org> To: Charlie Li X-Mailer: Apple Mail (2.3864.300.41.1.7) > On 8. Feb 2026, at 09:45, Michael Tuexen wrote: >=20 >> On 7. Feb 2026, at 16:34, Charlie Li wrote: >>=20 >> Michael Tuexen wrote: >>> The branch main has been updated by tuexen: >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D7b6e84c9ac5668134ab2d075019ef0b8= 27d90c84 >>> commit 7b6e84c9ac5668134ab2d075019ef0b827d90c84 >>> Author: Michael Tuexen >>> AuthorDate: 2026-01-31 10:42:10 +0000 >>> Commit: Michael Tuexen >>> CommitDate: 2026-01-31 10:42:10 +0000 >>> ure: improve checksum offloading >>> This patch fixes three issues: >>> (1) Initially, set the hwassist flags correctly when enabling >>> transmit checksum offload for TCP/IPv6 and UDP/IPv6. >>> (2) Keep the hwassist flags in sync with the capabilities when >>> changing txcsum. >>> (3) Keep the hwasssit flags in sync with the capabilities when >>> changing txcsum6. >>> Without this patch, transmit checksum offloading for TCP/IPv6 and >>> UDP/IPv6 is never used and transmit checksum offloading for IPv4, >>> TCP/IPv4 and UDP/IPv4 is always used, even if disabled via >>> ifconfig ue? -txcsum. >>> Reviewed by: Timo V=C3=B6lker >>> MFC after: 3 days >>> Differential Revision: https://reviews.freebsd.org/D54974 >>> --- >>> sys/dev/usb/net/if_ure.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> diff --git a/sys/dev/usb/net/if_ure.c b/sys/dev/usb/net/if_ure.c >>> index c3f7b622d687..3dea88eb10f1 100644 >>> --- a/sys/dev/usb/net/if_ure.c >>> +++ b/sys/dev/usb/net/if_ure.c >>> @@ -1015,6 +1015,7 @@ ure_attach_post_sub(struct usb_ether *ue) >>> if_sethwassist(ifp, CSUM_IP|CSUM_IP_UDP|CSUM_IP_TCP); >>> #ifdef INET6 >>> if_setcapabilitiesbit(ifp, IFCAP_HWCSUM_IPV6, 0); >>> + if_sethwassistbits(ifp, CSUM_IP6_UDP|CSUM_IP6_TCP, 0); >>> #endif >>> if_setcapenable(ifp, if_getcapabilities(ifp)); >>> @@ -1463,6 +1464,7 @@ ure_ioctl(if_t ifp, u_long cmd, caddr_t data) >>> if ((mask & IFCAP_TXCSUM) !=3D 0 && >>> (if_getcapabilities(ifp) & IFCAP_TXCSUM) !=3D 0) { >>> if_togglecapenable(ifp, IFCAP_TXCSUM); >>> + if_togglehwassist(ifp, CSUM_IP|CSUM_IP_UDP|CSUM_IP_TCP); >>> } >>> if ((mask & IFCAP_RXCSUM) !=3D 0 && >>> (if_getcapabilities(ifp) & IFCAP_RXCSUM) !=3D 0) { >>> @@ -1471,6 +1473,7 @@ ure_ioctl(if_t ifp, u_long cmd, caddr_t data) >>> if ((mask & IFCAP_TXCSUM_IPV6) !=3D 0 && >>> (if_getcapabilities(ifp) & IFCAP_TXCSUM_IPV6) !=3D 0) { >>> if_togglecapenable(ifp, IFCAP_TXCSUM_IPV6); >>> + if_togglehwassist(ifp, CSUM_IP6_UDP|CSUM_IP6_TCP); >>> } >>> if ((mask & IFCAP_RXCSUM_IPV6) !=3D 0 && >>> (if_getcapabilities(ifp) & IFCAP_RXCSUM_IPV6) !=3D 0) { >> It seems that with this commit, all network traffic and then some, = excluding ICMP{,v6}, time out. Even `route(8) get default` takes forever = to query. > Do you use a GENERIC kernel? > What is the output of > ifconfig ue0 > and (if you compiled and installed tools/tools/ifinfo/) > ifinfo ue0 >=20 > What happens if you run as root > ifconfig ue0 -txcsum > and/or > ifconfig ue0 -txcsum6 > Does the problem persist? >=20 > This commit should actually only let the host stack know that TCP/IPv6 = and UDP/IPv6 > transmit checksum offload is enabled. It should not affect TCP/IPv4 = and UDP/IPv4 > transmit checksum offload (except that you can now disable it). > Is any other network interface (like epair, bridge, ...) involved? I did some more testing: It seems that transmit checksum offloading for = TCP/IPv6 and UDP/IPv6 does not work correctly. So does ifconfig ue0 -txcsum6 resolve the networking problem for you? Best regards Michael >=20 > Best regards > Michael >>=20 >> --=20 >> Charlie Li >> ...nope, still don't have an exit line. >>=20 >=20 >=20