From owner-freebsd-arch Mon Mar 24 8:32: 2 2003 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B474637B401 for ; Mon, 24 Mar 2003 08:31:57 -0800 (PST) Received: from mail.nsu.ru (mx.nsu.ru [193.124.215.71]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF40643F85 for ; Mon, 24 Mar 2003 08:31:56 -0800 (PST) (envelope-from fjoe@iclub.nsu.ru) Received: from drweb by mail.nsu.ru with drweb-scanned (Exim 3.20 #1) id 18xUqh-0000pb-00; Mon, 24 Mar 2003 22:30:59 +0600 Received: from iclub.nsu.ru ([193.124.215.97] ident=root) by mail.nsu.ru with esmtp (Exim 3.20 #1) id 18xUqg-0000oO-00; Mon, 24 Mar 2003 22:30:58 +0600 Received: from iclub.nsu.ru (fjoe@localhost [127.0.0.1]) by iclub.nsu.ru (8.12.8/8.12.8) with ESMTP id h2OGUgj1096445; Mon, 24 Mar 2003 22:30:42 +0600 (NS) (envelope-from fjoe@iclub.nsu.ru) Received: (from fjoe@localhost) by iclub.nsu.ru (8.12.8/8.12.8/Submit) id h2OGUf0g096444; Mon, 24 Mar 2003 22:30:42 +0600 (NS) Date: Mon, 24 Mar 2003 22:30:41 +0600 From: Max Khon To: Johan Karlsson Cc: arch@freebsd.org, Sheldon Hearn Subject: Re: [fjoe@iclub.nsu.ru: Re: thread-safe realpath] Message-ID: <20030324223041.A96310@iclub.nsu.ru> References: <20030324212205.A94544@iclub.nsu.ru> <20030324154621.GA82437@numeri.campus.luth.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20030324154621.GA82437@numeri.campus.luth.se>; from k@numeri.campus.luth.se on Mon, Mar 24, 2003 at 04:46:21PM +0100 X-Envelope-To: k@numeri.campus.luth.se, arch@freebsd.org, sheldonh@starjuice.net X-Spam-Status: No, hits=-24.6 required=5.0 tests=AWL,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, QUOTE_TWICE_1,REFERENCES,REPLY_WITH_QUOTES,USER_AGENT_MUTT autolearn=ham version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG hi, there! On Mon, Mar 24, 2003 at 04:46:21PM +0100, Johan Karlsson wrote: > > > Constantin Svintsoff has submitted thread-safe realpath() implementation > > > (implementation that does not use chdir(2)). > > > The implementation is feature-compatible with FreeBSD implementation, i.e. > > > if the last component of specified path can't be stat'ed and there is no > > > trailing slash, realpath succeeds. > > > > > > I fixed a couple of bugs in it and would like to commit it to HEAD > > > if there will be no objections. > > > > > > Test program is attached. The test simply creates two threads and calls > > > realpath() in each. If the test is compiled with truepath() #if-0'ed > > > one of the assertions fail after some time (you may need to increase > > > number of iterations if you have very fast machine, mine is Athlon 850). > > > > > > Any comments are highly appreciated. > > How does this affect PR 12244? > I've sent a patch to -audit for review a month ago and I'm about > to commit that (just doing a final make universe). > http://docs.freebsd.org/cgi/getmsg.cgi?fetch=0+0+archive/2003/freebsd-audit/20030209.freebsd-audit I do not think that this patch is needed if Constantin's version will be committed. I plan to do this in about a week. /fjoe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message