From owner-svn-ports-head@FreeBSD.ORG Thu Sep 19 08:05:06 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 6143095; Thu, 19 Sep 2013 08:05:06 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 35F7C2BFF; Thu, 19 Sep 2013 08:05:06 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r8J856Jt009013; Thu, 19 Sep 2013 08:05:06 GMT (envelope-from bapt@svn.freebsd.org) Received: (from bapt@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r8J855cW009011; Thu, 19 Sep 2013 08:05:05 GMT (envelope-from bapt@svn.freebsd.org) Message-Id: <201309190805.r8J855cW009011@svn.freebsd.org> From: Baptiste Daroussin Date: Thu, 19 Sep 2013 08:05:05 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r327601 - head/Mk X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2013 08:05:06 -0000 Author: bapt Date: Thu Sep 19 08:05:05 2013 New Revision: 327601 URL: http://svnweb.freebsd.org/changeset/ports/327601 Log: Move the target for sanity checking to the end of bsd.port.mk so that WARNING and DEV_* can be defined anywhere While here, change sleep time from 5 to 10 so that users have time to read it [1] Suggested by: many [1] Modified: head/Mk/bsd.port.mk head/Mk/bsd.sanity.mk Modified: head/Mk/bsd.port.mk ============================================================================== --- head/Mk/bsd.port.mk Thu Sep 19 07:50:29 2013 (r327600) +++ head/Mk/bsd.port.mk Thu Sep 19 08:05:05 2013 (r327601) @@ -6491,6 +6491,43 @@ install-license: @${DO_NADA} .endif +.if defined(WARNING) +show-warnings: + @${ECHO_MSG} "/!\\ WARNING /!\\" +.for m in ${WARNING} + @${ECHO_MSG} "${m}" +.endfor + @${ECHO_MSG} + @sleep 10 + +check-makefile:: show-warnings +.endif + +.if defined(DEVELOPER) +.if defined(DEV_WARNING) +show-dev-warnings: + @${ECHO_MSG} "/!\\ ${PKGNAME}: Makefile warnings, please consider fixing /!\\" + @${ECHO_MSG} +.for m in ${DEV_WARNING} + @${ECHO_MSG} "${m}" +.endfor + @${ECHO_MSG} + @sleep 10 +check-makefile:: show-dev-warnings +.endif + +.if defined(DEV_ERROR) +show-dev-errors: + @${ECHO_MSG} "/!\\ ${PKGNAME}: Makefile errors /!\\" + @${ECHO_MSG} +.for m in ${DEV_WARNING} + @${ECHO_MSG} "${m}" +.endfor + @${ECHO_MSG} + @${FALSE} +check-makefile:: show-dev-errors +.endif +.endif #DVELOPER .endif # End of post-makefile section. Modified: head/Mk/bsd.sanity.mk ============================================================================== --- head/Mk/bsd.sanity.mk Thu Sep 19 07:50:29 2013 (r327600) +++ head/Mk/bsd.sanity.mk Thu Sep 19 08:05:05 2013 (r327601) @@ -91,41 +91,6 @@ DEV_WARNING+= "USE_GNOME=ltverhack is no DEV_WARNING+= "Please use the new format for LIB_DEPENDS, see handbook for details" .endif -.if defined(WARNING) -show-warnings: -.for m in ${WARNING} - @${ECHO_MSG} "${m}" -.endfor - @sleep 5 - -check-makefile:: show-warnings -.endif - .if defined(_PREMKINCLUDED) DEV_ERROR+= "you cannot include bsd.port[.pre].mk twice" .endif - -.if defined(DEVELOPER) -.if defined(DEV_WARNING) -show-dev-warnings: - @${ECHO_MSG} "/!\\ ${PKGNAME}: Makefile warnings, please consider fixing /!\\" - @${ECHO_MSG} -.for m in ${DEV_WARNING} - @${ECHO_MSG} "${m}" -.endfor - @${ECHO_MSG} - @sleep 5 -check-makefile:: show-dev-warnings -.endif - -.if defined(DEV_ERROR) -show-dev-errors: - @${ECHO_MSG} "/!\\ ${PKGNAME}: Makefile errors /!\\" - @${ECHO_MSG} -.for m in ${DEV_WARNING} - @${ECHO_MSG} "${m}" -.endfor - @${FALSE} -check-makefile:: show-dev-errors -.endif -.endif