From owner-svn-src-all@FreeBSD.ORG Sat Sep 13 06:05:54 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9B1BF90A; Sat, 13 Sep 2014 06:05:54 +0000 (UTC) Received: from anubis.delphij.net (anubis.delphij.net [64.62.153.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anubis.delphij.net", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 7B326F88; Sat, 13 Sep 2014 06:05:54 +0000 (UTC) Received: from delphij-macbook.local (unknown [1.202.73.210]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id 8125A5E3B; Fri, 12 Sep 2014 23:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphij.net; s=anubis; t=1410588353; x=1410602753; bh=lnr/S0UoLTpFVRa5gZcasbCYqdK00Q1uthGFQdR2bVY=; h=Date:From:Reply-To:To:CC:Subject:References:In-Reply-To; b=s9wvZNyqBSv06PmJw2Wo/AXc5IVvtIGBb72YiMHaDdHuF62ovZ0ztGgEyGhf9c1QC Nb3VrlSSIjkk4vpKW92ivdP87UkJegW0gkTeRmci7F6HQalGbqhciWkAvIZ1I7cGV6 ++H22xIIRiR7N1ZkD8QF5m36otOebozc0BXPHW24= Message-ID: <5413DEBE.7060301@delphij.net> Date: Sat, 13 Sep 2014 14:05:50 +0800 From: Xin Li Reply-To: d@delphij.net Organization: The FreeBSD Project MIME-Version: 1.0 To: John-Mark Gurney , d@delphij.net Subject: Re: svn commit: r269964 - head/sys/kern References: <201408140531.s7E5VeWw077792@svn.freebsd.org> <5413C6C1.7090308@delphij.net> <20140913052241.GU82175@funkthat.com> In-Reply-To: <20140913052241.GU82175@funkthat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , Adrian Chadd , "src-committers@freebsd.org" , Xin LI , "svn-src-all@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Sep 2014 06:05:54 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 9/13/14 1:22 PM, John-Mark Gurney wrote: > Xin Li wrote this message on Sat, Sep 13, 2014 at 12:23 +0800: >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 >> >> On 9/13/14 3:41 AM, Adrian Chadd wrote: >>> Hi guys, >>> >>> Both r269963 and r269964 have broken the MIPS platforms with >>> smaller amounts of RAM (< 64MB.) >>> >>> Sean noticed it and filed a bug: >>> >>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193465 >>> >>> Can we please figure out what changed? Otherwise I'm going to >>> revert these two changes until we figure out what happened. >> >> Could you please try if this would mitigate the issue? >> >> Index: sys/kern/kern_malloc.c >> =================================================================== >> >> - - --- sys/kern/kern_malloc.c (revision 271494) >> +++ sys/kern/kern_malloc.c (working copy) @@ -717,6 +717,8 >> @@ kmeminit(void) * a given architecture. */ mem_size = >> vm_cnt.v_page_count; + if (mem_size <= 32768) /* delphij >> XXX 128MB */ + kmem_zmax = PAGE_SIZE; >> >> if (vm_kmem_size_scale < 1) vm_kmem_size_scale = >> VM_KMEM_SIZE_SCALE; >> > > Has more research been done on this? My 64MB AVILA board boots > fine, and ath attaches fine... It's theoretically possible that my change brings a regression for small system, as the larger allocation units now "caches" the allocation instead of returning them immediately. Sean also confirms that reverting the two changes only would fix the issue, so I think we should use some autotune here. Cheers, -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJUE96+AAoJEJW2GBstM+nsb6AP/RrwGeuuNUVpfHhOqIaZEBm3 vtYINve38oxTF9D3FCONWpib7/ZggSfdN7kkSJ5oKNbjJtrbhqqIrhuKNyo03L7o WbR3TLam0+8tCYL7EYe93D6wqWlkyPZkOv4G1amh2UxwWnfhP/uruLA/LJPm/z/+ 41gT2DHRUDj9JmeDt4R7EPIO7UOZ9uqs+dJ8mpx0hvxvTUgxR94umtX5/Ijmp6Fj MHuiVjgkJ9DM6RHlXECenYj8gTEbwV8MVNQhoIrlqDSbZsy+O4FMek3byFy6OL9U pPd9O/QDHCfPoOK12RULv3+7c6NhXXiVYU3RoBrwDEJx5XhfG8bvrdRZha2JgJkz KwyVBKqMXH6QjhRFtisgd630cchew7XO+21TK5zeKt0sad6CETLJyIsiHuOkHYI3 vFkIPGu3uF9YFMzacqiQKydhaN/6chQYh2vlmxpcnuiP3ispfJjZyPyCCs1vadip 5uJkG0bIHb/kQZJ8LouEk+W9QA0XUlIaYbP0JxzTMqvH5iyqMTId9XgsVgqWK/th XrCGzXuoi5fQw0NauhdKoihJeJ/Ut+7cblv6h7IpmLFEDUJZvVtgYcaZOsOhC2FG 4C//ENzbcioBimvujnktvOJEwT7XpoBwuIcfIVoz/tMZYgx3y5w1mRIGUoh1/XAP kTQmYqaG5A1CrBEFPeOI =i4ee -----END PGP SIGNATURE-----