From owner-cvs-src@FreeBSD.ORG Tue Sep 26 04:14:11 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C99C116A412; Tue, 26 Sep 2006 04:14:11 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id 68F0C43D5D; Tue, 26 Sep 2006 04:14:11 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (h57xvhyefrp14fo8@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id k8Q4E8Dj008425; Mon, 25 Sep 2006 21:14:08 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id k8Q4E7CD008424; Mon, 25 Sep 2006 21:14:07 -0700 (PDT) (envelope-from jmg) Date: Mon, 25 Sep 2006 21:14:07 -0700 From: John-Mark Gurney To: "Andrew R. Reiter" Message-ID: <20060926041406.GE80527@funkthat.com> References: <200609260121.k8Q1Llo8049117@repoman.freebsd.org> <20060925215235.C46437@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060925215235.C46437@fledge.watson.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp_input.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2006 04:14:11 -0000 Andrew R. Reiter wrote this message on Mon, Sep 25, 2006 at 21:53 -0400: > On Tue, 26 Sep 2006, John-Mark Gurney wrote: > > :jmg 2006-09-26 01:21:47 UTC > : > : FreeBSD src repository > : > : Modified files: > : sys/netinet tcp_input.c > : Log: > : fix calculating to_tsecr... This prevents the rtt calculations from > : going all wonky... > : > : Revision Changes Path > : 1.309 +1 -1 src/sys/netinet/tcp_input.c > > At some point will it be safe to remove that min/max check? Do you mean replace the else? or do you mean change it entirely? Unless someone can think of a reason why the retransmit timer should ever be allowed to go above 64 seconds, I'd consider replacing the else, but as I see it, it prevents run away code, though w/o the else I probably wouldn't of found this bug... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."