From owner-p4-projects@FreeBSD.ORG Tue Jan 1 19:08:25 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 03B1916A474; Tue, 1 Jan 2008 19:08:25 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A8C4D16A417; Tue, 1 Jan 2008 19:08:24 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 6B54F13C455; Tue, 1 Jan 2008 19:08:24 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.1/8.14.1) with ESMTP id m01J5rod036494; Tue, 1 Jan 2008 12:05:53 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 01 Jan 2008 12:06:01 -0700 (MST) Message-Id: <20080101.120601.106977236.imp@bsdimp.com> To: jb@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <200712310531.lBV5VvH3092205@repoman.freebsd.org> References: <200712310531.lBV5VvH3092205@repoman.freebsd.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: perforce@FreeBSD.org Subject: Re: PERFORCE change 132153 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jan 2008 19:08:25 -0000 In message: <200712310531.lBV5VvH3092205@repoman.freebsd.org> John Birrell writes: : http://perforce.freebsd.org/chv.cgi?CH=132153 : : Change 132153 by jb@jb_freebsd1 on 2007/12/31 05:31:02 : : amd64 doesn't seem to have a program header in the kernel modules : like i386 does. I don't know enough about amd64 to know if that's a : problem or not. I have a feeling I'm not far off learning that. :-P I believe that amd64 is the only one that doesn't... Warner : Affected files ... : : .. //depot/projects/dtrace/src/contrib/opensolaris/lib/libdtrace/common/dt_module.c#14 edit : : Differences ... : : ==== //depot/projects/dtrace/src/contrib/opensolaris/lib/libdtrace/common/dt_module.c#14 (text) ==== : : @@ -927,6 +927,7 @@ : #if defined(sun) : dmp->dm_modid = (int)OBJFS_MODID(st.st_ino); : #else : +#if defined(__i386__) : /* : * Find the first load section and figure out the relocation : * offset for the symbols. The kernel module will not need : @@ -939,6 +940,7 @@ : } : } : #endif : +#endif