Date: Thu, 26 Jan 2017 13:48:51 +0000 From: "David_A_Bright_DELL.com (David A. Bright)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D9345: ifnet: move the new ifnet_event EVENTHANDLER_DECLARE to net/if_var.h Message-ID: <33f6dd8d5147a416bbd41d93158a5243@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-ehgwxeotuhsw6eo52uz6-req@FreeBSD.org> References: <differential-rev-PHID-DREV-ehgwxeotuhsw6eo52uz6-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
David_A_Bright_DELL.com added a comment. Just a couple style nits. INLINE COMMENTS > if_var.h:407 > EVENTHANDLER_DECLARE(ifnet_link_event, ifnet_link_event_handler_t); > +/* Interface up/ifdown event */ > +#define IFNET_EVENT_UP 0 I would stick with the previous "ifup/ifdown" or go with "Interface up/down". I think "Interface up/ifdown" reads poorly. > if_var.h:408 > +/* Interface up/ifdown event */ > +#define IFNET_EVENT_UP 0 > +#define IFNET_EVENT_DOWN 1 It would be nice to have the 0/1 values for these two defines line up. In any case, it definitely seems like there is extraneous whitespace between "IFNET_EVENT_UP" and "0". REVISION DETAIL https://reviews.freebsd.org/D9345 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: decui_microsoft.com, hselasky, sepherosa_gmail.com, cem, np, kmacy, kib, honzhan_microsoft.com, howard0su_gmail.com, jhb, ae, delphij, royger, glebius, gnn, rwatson Cc: David_A_Bright_DELL.com, freebsd-net-list
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?33f6dd8d5147a416bbd41d93158a5243>