From owner-svn-src-all@freebsd.org Tue Oct 8 10:36:21 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 99D1D14360F; Tue, 8 Oct 2019 10:36:21 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46nYfs3WlRz3G2C; Tue, 8 Oct 2019 10:36:21 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-oi1-f196.google.com with SMTP id w144so14342097oia.6; Tue, 08 Oct 2019 03:36:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jz7Lw/XGIQ19IkiOZYP4d6kiGlFDICZnNwDhq8OSyZs=; b=ffm2ClVmNTQOsbkOrtdz8WR76hb0c3lFi0MXOxIc4/LX5UVQ6agkY4SEEOpaZkYxex L9xG0WIZV4tT7eNDz5MeEeosYxbGzj5Bn4J54gsnK2FU+uEB29APNhKVKjEb/DiciPRS tWF8YzWX6qUdxxyto4lMSRMxNIM23gSpij4M9yI0QJVwTl8yY3/2bDAs5CIxjblLMHTE Rf38NFZ63f2hZB0hU7NxyQFKjcklzOn5wYJa6cAsHIggpMQz3VjS5HILzK7FVOxRSe9E /KjKxEovPKRSvSPdWmpFbxe0e5WETVGbxwHKX0rfXEkBS6v5IW3+7rG9N7BlPJp8Qlx9 EwWg== X-Gm-Message-State: APjAAAX8dVPJHZz4gCL+pL+9E5IojXHQUT+OU8mq/jJZDRz9WJXNaGXD Th9I2wR+q3nkNhFe1sGNavEXEhpBLMwcTUA8r+IU9Q== X-Google-Smtp-Source: APXvYqxqbHMGPzqkMmPzp9gXN+JpcqjXdMWCob/O4iXrENdnVmXeH3jR4So+W7LbTNorMt5+8FaPkDCfaOGwipc62qM= X-Received: by 2002:aca:b142:: with SMTP id a63mr3164507oif.119.1570530979252; Tue, 08 Oct 2019 03:36:19 -0700 (PDT) MIME-Version: 1.0 References: <201910071905.x97J56t0039812@repo.freebsd.org> <19168116-73e4-7d98-16d3-2ecd38dabfcd@FreeBSD.org> In-Reply-To: <19168116-73e4-7d98-16d3-2ecd38dabfcd@FreeBSD.org> From: Edward Napierala Date: Tue, 8 Oct 2019 11:36:06 +0100 Message-ID: Subject: Re: svn commit: r353283 - in head: lib lib/libstats share/man/man3 share/mk sys/amd64/conf sys/conf sys/kern sys/sys tools/build/options To: John Baldwin Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46nYfs3WlRz3G2C X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Oct 2019 10:36:21 -0000 On Mon, 7 Oct 2019 at 22:39, John Baldwin wrote: > > On 10/7/19 12:05 PM, Edward Tomasz Napierala wrote: > > Author: trasz > > Date: Mon Oct 7 19:05:05 2019 > > New Revision: 353283 > > URL: https://svnweb.freebsd.org/changeset/base/353283 > > > > Log: > > Introduce stats(3), a flexible statistics gathering API. > > > > This provides a framework to define a template describing > > a set of "variables of interest" and the intended way for > > the framework to maintain them (for example the maximum, sum, > > t-digest, or a combination thereof). Afterwards the user > > code feeds in the raw data, and the framework maintains > > these variables inside a user-provided, opaque stats blobs. > > The framework also provides a way to selectively extract the > > stats from the blobs. The stats(3) framework can be used in > > both userspace and the kernel. > > > > See the stats(3) manual page for details. > > > > This will be used by the upcoming TCP statistics gathering code, > > https://reviews.freebsd.org/D20655. > > > > The stats(3) framework is disabled by default for now, except > > in the NOTES kernel (for QA); it is expected to be enabled > > in amd64 GENERIC after a cool down period. > > Why sys/amd64/conf/NOTES instead of sys/conf/NOTES? The userland > library seems to be enabled for all architectures rather than only > amd64? Good point. My original thinking was to only enable it by default on amd64, since, well, it's "server-y stuff", but now I think of it, it doesn't make sense. > > Modified: head/share/man/man3/arb.3 > > ============================================================================== > > --- head/share/man/man3/arb.3 Mon Oct 7 18:55:40 2019 (r353282) > > +++ head/share/man/man3/arb.3 Mon Oct 7 19:05:05 2019 (r353283) > > @@ -30,7 +30,7 @@ > > .\" > > .\" $FreeBSD$ > > .\" > > -.Dd September 28, 2019 > > +.Dd October 2, 2019 > > .Dt ARB 3 > > .Os > > .Sh NAME > > @@ -94,7 +94,8 @@ > > .Nm ARB_INIT , > > .Nm ARB_INSERT , > > .Nm ARB_REMOVE , > > -.Nm ARB_REINSERT > > +.Nm ARB_REINSERT , > > +.Nm ARB_RESET_TREE > > .Nd "array-based red-black trees" > > .Sh SYNOPSIS > > .In sys/arb.h > > Are these changes related? Perhaps it would have been nice to commit this > change separately with its own description before the stats(3) commit if so. Which is exactly what I was intending to do, sigh. But yes, this chunk is specific to stats(3); in fact up until the last Phab revision it's been done directly in kern_stats.c.