From owner-freebsd-arch@FreeBSD.ORG Wed Mar 8 14:57:54 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E9E016A422 for ; Wed, 8 Mar 2006 14:57:54 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A2B243D46 for ; Wed, 8 Mar 2006 14:57:53 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (junior.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k28EuYIL019718; Wed, 8 Mar 2006 07:56:34 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <440EF0B0.1010203@samsco.org> Date: Wed, 08 Mar 2006 07:56:48 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20051230 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Peter Jeremy References: <20060307.233728.42821161.imp@bsdimp.com> <20060308092207.GB679@turion.vk2pj.dyndns.org> In-Reply-To: <20060308092207.GB679@turion.vk2pj.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org Cc: arch@freebsd.org Subject: Re: Fw: cvs commit: src/sys/vm swap_pager.c vm_fault.c vm_map.c vm_page.c vm_pageq.c X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2006 14:57:54 -0000 Peter Jeremy wrote: > On Tue, 2006-Mar-07 23:37:28 -0700, M. Warner Losh wrote: > >>This is the first commit of many to do what the comment says. > > ... > >> Log: >> Remove leading __ from __(inline|const|signed|volatile). They are >> obsolete. This should reduce diffs to NetBSD as well. > > > K&R function definitions are even more obsolete but still used > throughout the kernel. IMHO, potential diff-reduction to NetBSD > seems a fairly flimsy reason for a significant amount of churn. > > Also, any diff reduction with NetBSD is probably outweighed by > the diff increase with other FreeBSD branches. > > Maybe this should be treated like whitespace cleanup - something to > do if you're going to be doing something non-trivial in the source > file. (There are probably other cleanups in the same category). > Yeah, diff increase with other FreeBSD branches is a big deal. While sharing between RELENG_4 and more recent branches is pretty hard these days, a lot can be shared between RELENG_5, RELENG_6, and HEAD. Scott