From owner-svn-src-all@freebsd.org Sun Feb 7 15:40:03 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 21B2CAA04DE; Sun, 7 Feb 2016 15:40:03 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E3BC963E; Sun, 7 Feb 2016 15:40:02 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u17Fe1up012669; Sun, 7 Feb 2016 15:40:01 GMT (envelope-from pfg@FreeBSD.org) Received: (from pfg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u17Fe17B012668; Sun, 7 Feb 2016 15:40:01 GMT (envelope-from pfg@FreeBSD.org) Message-Id: <201602071540.u17Fe17B012668@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: pfg set sender to pfg@FreeBSD.org using -f From: "Pedro F. Giffuni" Date: Sun, 7 Feb 2016 15:40:01 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r295371 - head/sys/fs/fdescfs X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Feb 2016 15:40:03 -0000 Author: pfg Date: Sun Feb 7 15:40:01 2016 New Revision: 295371 URL: https://svnweb.freebsd.org/changeset/base/295371 Log: Revert r295359: CID 1018688 is a false positive. The initialization is done by calling vn_start_write(... &mp, flags). mp is only an output parameter unless (flags & V_MNTREF), and fdesc doesn't put V_MNTREF in flags. Pointed out by: bde Modified: head/sys/fs/fdescfs/fdesc_vnops.c Modified: head/sys/fs/fdescfs/fdesc_vnops.c ============================================================================== --- head/sys/fs/fdescfs/fdesc_vnops.c Sun Feb 7 15:36:16 2016 (r295370) +++ head/sys/fs/fdescfs/fdesc_vnops.c Sun Feb 7 15:40:01 2016 (r295371) @@ -465,7 +465,7 @@ fdesc_setattr(ap) { struct vattr *vap = ap->a_vap; struct vnode *vp; - struct mount *mp = NULL; + struct mount *mp; struct file *fp; struct thread *td = curthread; cap_rights_t rights;