From owner-svn-src-all@FreeBSD.ORG Fri Mar 16 23:24:27 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F1E0106566C; Fri, 16 Mar 2012 23:24:27 +0000 (UTC) (envelope-from adrian@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 8EBAA8FC15; Fri, 16 Mar 2012 23:24:27 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q2GNORS9039676; Fri, 16 Mar 2012 23:24:27 GMT (envelope-from adrian@svn.freebsd.org) Received: (from adrian@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q2GNORJx039674; Fri, 16 Mar 2012 23:24:27 GMT (envelope-from adrian@svn.freebsd.org) Message-Id: <201203162324.q2GNORJx039674@svn.freebsd.org> From: Adrian Chadd Date: Fri, 16 Mar 2012 23:24:27 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r233053 - head/sys/dev/ath X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2012 23:24:27 -0000 Author: adrian Date: Fri Mar 16 23:24:27 2012 New Revision: 233053 URL: http://svn.freebsd.org/changeset/base/233053 Log: Fix a couple of debugging outputs. * printf -> device_printf * print the buffer pointer and sequence number for any buffer that wasn't correctly tidied up before it was freed. This is to aid in some current SMP TX debugging stalls. PR: kern/166190 Modified: head/sys/dev/ath/if_ath.c Modified: head/sys/dev/ath/if_ath.c ============================================================================== --- head/sys/dev/ath/if_ath.c Fri Mar 16 23:19:45 2012 (r233052) +++ head/sys/dev/ath/if_ath.c Fri Mar 16 23:24:27 2012 (r233053) @@ -4795,10 +4795,16 @@ ath_tx_default_comp(struct ath_softc *sc if (bf->bf_state.bfs_dobaw) device_printf(sc->sc_dev, - "%s: dobaw should've been cleared!\n", __func__); + "%s: bf %p: seqno %d: dobaw should've been cleared!\n", + __func__, + bf, + SEQNO(bf->bf_state.bfs_seqno)); if (bf->bf_next != NULL) device_printf(sc->sc_dev, - "%s: bf_next not NULL!\n", __func__); + "%s: bf %p: seqno %d: bf_next not NULL!\n", + __func__, + bf, + SEQNO(bf->bf_state.bfs_seqno)); /* * Do any tx complete callback. Note this must @@ -5352,8 +5358,11 @@ ath_stoprecv(struct ath_softc *sc, int d struct ath_buf *bf; u_int ix; - printf("%s: rx queue %p, link %p\n", __func__, - (caddr_t)(uintptr_t) ath_hal_getrxbuf(ah), sc->sc_rxlink); + device_printf(sc->sc_dev, + "%s: rx queue %p, link %p\n", + __func__, + (caddr_t)(uintptr_t) ath_hal_getrxbuf(ah), + sc->sc_rxlink); ix = 0; TAILQ_FOREACH(bf, &sc->sc_rxbuf, bf_list) { struct ath_desc *ds = bf->bf_desc;