From owner-freebsd-hackers@freebsd.org Thu Oct 8 15:01:02 2015 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A0D629D247C for ; Thu, 8 Oct 2015 15:01:02 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ob0-x22a.google.com (mail-ob0-x22a.google.com [IPv6:2607:f8b0:4003:c01::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 69D41AA4 for ; Thu, 8 Oct 2015 15:01:02 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by obbda8 with SMTP id da8so40367121obb.1 for ; Thu, 08 Oct 2015 08:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=tB+qind8x+XEceajmMitghkptktqZrRcfCDm0LMKRTs=; b=Aq61BjU65YlGTF4uYxZ+u20EgGTDDMO1MqaUqUuGSDMSTCg1++Q+G1hqeziXGsetGf xHsCLCbNC6a4sZ9K5+LEyE+mbK/5eIQvclk9qT0lXDP0W5hLIYNiWwMkveU75LZqO8KS Aixvm+3bL56gEONQxf8vx2iYKB91Axi0CeaHTGs9lv6pgkPvQBerZGzud49uM6KCzDtm 0sro8RW2pcgWRUeO+GsibEUL3opLzSY6hJKfyGLPv4HaAAbi5tw8uPdA/cot2Ei/hmLL tWhvnNQJUMcOqIfv/HIkiGq9znYfB/nu1KgSysgbPwKr52eOPyyl+zjIexfVmkdd2DuP WtTg== MIME-Version: 1.0 X-Received: by 10.60.117.170 with SMTP id kf10mr4660255oeb.60.1444316461480; Thu, 08 Oct 2015 08:01:01 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.71.6 with HTTP; Thu, 8 Oct 2015 08:01:01 -0700 (PDT) In-Reply-To: <302195821622251047657@scdbackup.webframe.org> References: <302195821622251047657@scdbackup.webframe.org> Date: Thu, 8 Oct 2015 09:01:01 -0600 X-Google-Sender-Auth: i6fVYba5SeBnsocyOtBOck9Ykho Message-ID: Subject: Re: What to do with triaged Coverity complaints about makefs ? From: Alan Somers To: Thomas Schmitt Cc: "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 15:01:02 -0000 On Thu, Oct 8, 2015 at 3:49 AM, Thomas Schmitt wrote: > Hi, > > i now get to see the makefs complaints of Coverity. > (The trick was to try logging out, which failed, but then produced > the list of complaints and made the GUI willing to show details.) > > Many complaints are about the FFS aspect of makefs, of which i > have no clue. > Some more are about /usr.sbin/makefs/cd9660/cd9660_debug.c, > of which i do not really understand the purpose. > So i mainly cared for bugs related to ISO 9660 production. > > Two ISO 9660 related complaints are easy to understand, but > i currently lack the makefs background to decide how to > react on the miserable failure to write to disk. > > Meanwhile i got 9 diagnoses with remedy proposals (if real bug) > and 2 diagnoses without proposals. > > > Now what to do with my findings ? > > File 6 PRs for 974635+974636, 976312, 977470, 978431, 1008927, > 1305659 ? > > Fill out the Coverity "Triage" window at the right side of the > GUI ? (Am i entitled to do more than reading there ?) Filling out the Coverity triage info is good. Filing PRs is better. Doing both is better yet. But ultimately, the next step forward is to attract the attention of a developer who can review and commit your patches. Checking "svn log" for recent committers to that directory is a good idea, but you should probably exclude people who've only committed makefile and man page changes. In this case, marius, davide, and jmg look like good candidates. After your patches are committed, coverity will update the issues automatically on its next scan. It currently scans once every 2 or 3 weeks. -Alan