Date: Wed, 1 Dec 2010 10:38:10 +0200 From: Ion-Mihai Tetcu <itetcu@FreeBSD.org> To: "Ganael LAPLANCHE" <ganael.laplanche@martymac.org> Cc: FreeBSD Ports <ports@FreeBSD.org>, Mark Linimon <linimon@lonesome.com>, Ade Lovett <ade@FreeBSD.org> Subject: Re: CFR: patch to cleanup usage of SRC_BASE in various ports Message-ID: <20101201103810.46a1be7a@it.buh.tecnik93.com> In-Reply-To: <20101130211524.M4648@martymac.org> References: <20101130041323.GA17404@lonesome.com> <4CF51A1F.7030803@gmail.com> <20101130191906.GA28560@lonesome.com> <60D0FDFC-83B5-479D-97ED-922A6D31EF87@FreeBSD.org> <20101130211524.M4648@martymac.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/xeeLEmIuESqflQrOTfPULj7 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 30 Nov 2010 22:16:17 +0100 (CET) "Ganael LAPLANCHE" <ganael.laplanche@martymac.org> wrote: > On Tue, 30 Nov 2010 14:09:35 -0600, Ade Lovett wrote >=20 > Hi Ade, hi Mark ! >=20 > > > Patch incorporating these suggestions, along with some other edge > > > cases I found, uploaded: > > >=20 > > > http://people.freebsd.org/~linimon/patches/diff.out.srcbase > >=20 > > http://people.FreeBSD.org/~ade/bpm.src_base.diff > >=20 > > Trivial addition to Mk/bsd.port.mk to prevent duplication of=20 > > SRC_BASE?=3D ... in individual port Makefiles. >=20 > Good patches, thanks ! But couldn't we extend this idea ? >=20 > Most of the time, ${SRC_BASE} is used to check whether some file > (mostly ${SRC_BASE}/sys/Makefile) exists or not, to return,=20 > most of the time, the same error :=20 > =20 > "you need to extract kernel source tree before building this package" > =20 > It would be interesting to provide something like : >=20 > USE_BASE=3D yes=20 > Which would do the following : > =3D> defines ${SRC_BASE} > =3D> checks for ${SRC_BASE}/sys/Makefile > =3D> provides a standard error msg if not found >=20 > or, if set to something other than yes : >=20 > USE_BASE=3D some/file/within/src_base > =3D> defines ${SRC_BASE} > =3D> check for ${SRC_BASE}/some/file/within/src_base > =3D> provides a standard error msg if not found >=20 > Thus, we would avoid having the same tests again and again, and be=20 > able to provide more "standard" messages... >=20 > What do you think ? Yes. It would help tracking some errors on automated build systems. --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B --Sig_/xeeLEmIuESqflQrOTfPULj7 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iEYEARECAAYFAkz2CXIACgkQJ7GIuiH/oeWIAQCgrOuoqPU4FRm6UCaxUROpKAWn 5s4AoJZZlHsNxhJlTxr8IO7xF0/hm9hi =9TOs -----END PGP SIGNATURE----- --Sig_/xeeLEmIuESqflQrOTfPULj7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101201103810.46a1be7a>