Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Dec 2012 01:17:50 +0000 (UTC)
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r244577 - head/sys/net80211
Message-ID:  <201212220117.qBM1HoUC077766@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: adrian
Date: Sat Dec 22 01:17:49 2012
New Revision: 244577
URL: http://svnweb.freebsd.org/changeset/base/244577

Log:
  if_start() is being used here as a way of kick-starting the new queue
  processing.  For if_transmit() style hardware drivers (which none publicly
  exist yet, for wireless) they will need to still implement if_start()
  but only to re-start the TX queue.

Modified:
  head/sys/net80211/ieee80211_proto.c

Modified: head/sys/net80211/ieee80211_proto.c
==============================================================================
--- head/sys/net80211/ieee80211_proto.c	Sat Dec 22 01:16:28 2012	(r244576)
+++ head/sys/net80211/ieee80211_proto.c	Sat Dec 22 01:17:49 2012	(r244577)
@@ -1787,6 +1787,11 @@ ieee80211_newstate_cb(void *xvap, int np
 		IF_LOCK(&vap->iv_ifp->if_snd);
 		vap->iv_ifp->if_drv_flags &= ~IFF_DRV_OACTIVE;
 		IF_UNLOCK(&vap->iv_ifp->if_snd);
+
+		/*
+		 * XXX Kick-start a VAP queue - this should be a method,
+		 * not if_start()!
+		 */
 		if_start(vap->iv_ifp);
 
 		/* bring up any vaps waiting on us */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201212220117.qBM1HoUC077766>