From owner-svn-src-all@FreeBSD.ORG  Sat Dec 22 01:17:50 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 533EB6BF;
 Sat, 22 Dec 2012 01:17:50 +0000 (UTC)
 (envelope-from adrian@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id 384E98FC13;
 Sat, 22 Dec 2012 01:17:50 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
 by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id qBM1HoIp077767;
 Sat, 22 Dec 2012 01:17:50 GMT (envelope-from adrian@svn.freebsd.org)
Received: (from adrian@localhost)
 by svn.freebsd.org (8.14.5/8.14.5/Submit) id qBM1HoUC077766;
 Sat, 22 Dec 2012 01:17:50 GMT (envelope-from adrian@svn.freebsd.org)
Message-Id: <201212220117.qBM1HoUC077766@svn.freebsd.org>
From: Adrian Chadd <adrian@FreeBSD.org>
Date: Sat, 22 Dec 2012 01:17:50 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r244577 - head/sys/net80211
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Dec 2012 01:17:50 -0000

Author: adrian
Date: Sat Dec 22 01:17:49 2012
New Revision: 244577
URL: http://svnweb.freebsd.org/changeset/base/244577

Log:
  if_start() is being used here as a way of kick-starting the new queue
  processing.  For if_transmit() style hardware drivers (which none publicly
  exist yet, for wireless) they will need to still implement if_start()
  but only to re-start the TX queue.

Modified:
  head/sys/net80211/ieee80211_proto.c

Modified: head/sys/net80211/ieee80211_proto.c
==============================================================================
--- head/sys/net80211/ieee80211_proto.c	Sat Dec 22 01:16:28 2012	(r244576)
+++ head/sys/net80211/ieee80211_proto.c	Sat Dec 22 01:17:49 2012	(r244577)
@@ -1787,6 +1787,11 @@ ieee80211_newstate_cb(void *xvap, int np
 		IF_LOCK(&vap->iv_ifp->if_snd);
 		vap->iv_ifp->if_drv_flags &= ~IFF_DRV_OACTIVE;
 		IF_UNLOCK(&vap->iv_ifp->if_snd);
+
+		/*
+		 * XXX Kick-start a VAP queue - this should be a method,
+		 * not if_start()!
+		 */
 		if_start(vap->iv_ifp);
 
 		/* bring up any vaps waiting on us */