From nobody Tue Jan 27 21:13:43 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f0ynS5Bhzz6QRfN for ; Tue, 27 Jan 2026 21:13:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f0ynS4WvQz3kq0 for ; Tue, 27 Jan 2026 21:13:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769548428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gytLY56ko3rl1/TAWgUjUCTBBp2ZWHl8i+Icc8k1hTo=; b=JlmWWJe1faU6HRQSPx2VXNZkmHL0LgfSS1+AMbsGi3u172+u3kiWwsHMB549iuAZaiEiPN 3Y/zvDe36A7HORTAihHWfCJRgYcjMSH+Bsi937+Zlx3Tc77XD+PM0e9PL77XJ8ICE3viDX E4JUYyadyz23vnEsWl7vPhh9VPk+Z4Dr0+spLgCL4fKJQFvT8caAViYT/Ws9Ce8OKltDUr 7Vj8i5T809me9rP0CCdIkO2GjbppRJ2aUkTHp3WrlYsY6ijSIVqac6v2MdQ5lAKOzV6phU m8O0quI7jfSXzfpyYW0EAK6CSY1AkyIEfVltKVr9iv8acuw9gy81KrAb1yf0qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769548428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gytLY56ko3rl1/TAWgUjUCTBBp2ZWHl8i+Icc8k1hTo=; b=fW40dxO1qZyTBl0uxv3kZ5/nURxkIEwcdQUvM8UE9cA32CJ6mmMnErKyfmOOy2agboFLK9 EP6TlPYkXJffgF9Y5tx9NnrtoeQ0CqgbIPzYU1dKh42eJbL9C0QaOuX+N+sOdjXmHF+7s/ pSqodklPNfUx/dQSjrQQZRUJTsYD5n6lfev+1zpfGTRTHaGM82uvsn0FQo5yLeYjRn4gkh 3i2pD4bz3fELhGxyj5FdIbUNzoh/tQUDZNzDMnukvUQR1b+CTATciBZMbapxY3AGIW1/ro EeCLczkLVEXBsrex2A3Ym+r+qbFZyX1iGG3cXh8azT87Qj54RB3vy2bKpMgpgw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769548428; a=rsa-sha256; cv=none; b=XgBFJI8dj1ceWku6MBWQRyaQudQ5lmxJWk635GA2Q+4XmZvZrFiquQgN7JAeKfaRCA9GFc zKLxrnmzvI9+DJHCefhzNIJnyZRamZtzoTduTemZKbB6JJe/HPOPSs15F9eQEbKjm9RUF+ /NKU0fPAmMcTaAoUVdJKvx8kteG875ICE7Ojcrk968hRYwF3p+uC7Dh1RH1Q25nuaw6p/K GfR0c1uwWe27gbX4b8A72qqqcH25Hx4v+inwqER1Q6hlm8rMgsUnGDI7EJpRayAn1QG3Fp j8vu/X3W9z9H+9W3ESOJsDNLgc+2nUVOIz+R2C0J33ZK2u0fqgBtjQWjBcVvsg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f0ynS3r1Jz7bd for ; Tue, 27 Jan 2026 21:13:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 36521 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 27 Jan 2026 21:13:43 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 938915a22c84 - main - netbsd-tests: Fix regcomp_too_big flakiness List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 938915a22c84af88afa587694e8d63ce9dd202f4 Auto-Submitted: auto-generated Date: Tue, 27 Jan 2026 21:13:43 +0000 Message-Id: <69792a87.36521.160e4181@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=938915a22c84af88afa587694e8d63ce9dd202f4 commit 938915a22c84af88afa587694e8d63ce9dd202f4 Author: Mark Johnston AuthorDate: 2026-01-27 21:08:35 +0000 Commit: Mark Johnston CommitDate: 2026-01-27 21:08:35 +0000 netbsd-tests: Fix regcomp_too_big flakiness The test sometimes crashes with ASLR enabled. This seems to happen when regcomp() grows the process stack and happens to run into the virtual memory limit set at the beginning of the test. ASLR triggers the problem since it introduces a bit of fragmentation and thus introduces cases where stack allocation can be the trigger of virtual memory exhaustion, rather than dynamic memory allocation in regcomp(). Make the test stable by priming the stack before doing anything else. This effectively reserves 16MB of virtual memory for the stack, which in practice is enough to make the test stable on amd64. PR: 259971 Reviewed by: ngie, emaste MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D54880 --- contrib/netbsd-tests/lib/libc/regex/t_exhaust.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c b/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c index 2f3d1025536b..9741f3311ae0 100644 --- a/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c +++ b/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c @@ -168,6 +168,14 @@ static const struct { { p6, REG_BASIC }, }; +static void __noinline +prime_stack(void) +{ + char buf[16 * 1024 * 1024]; + + explicit_bzero(buf, sizeof(buf)); +} + ATF_TC(regcomp_too_big); ATF_TC_HEAD(regcomp_too_big, tc) @@ -186,12 +194,15 @@ ATF_TC_BODY(regcomp_too_big, tc) int e; struct rlimit limit; - if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false)) - atf_tc_skip("https://bugs.freebsd.org/259971"); - limit.rlim_cur = limit.rlim_max = 256 * 1024 * 1024; ATF_REQUIRE(setrlimit(RLIMIT_VMEM, &limit) != -1); + /* + * Pre-fault the stack to avoid crashes caused by growing the stack + * beyond the limit. + */ + prime_stack(); + for (size_t i = 0; i < __arraycount(tests); i++) { char *d = (*tests[i].pattern)(REGEX_MAXSIZE); e = regcomp(&re, d, tests[i].type);