From nobody Thu Jul 27 20:12:57 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RBhll0jqGz4pdjg; Thu, 27 Jul 2023 20:12:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RBhlZ04fQz3MyS; Thu, 27 Jul 2023 20:12:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690488778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=23t6kzSCt2YmMsqkNDZ9J38vQ1M/6lsjtbTCbTItChE=; b=ADyswW9PQbUW7bZC8hhZz8b+cA2vZZpmQYiPobh1tQ1BNWHEuTVhKPQDMik1Jx9k1lY/ZE GFbPfh4QPrzNCa0dipkyY2y5P1ugvFyNF6TEPHF5nv5tE8b48TVKdP+/jYG69jXI308N0a ln/OdVk0Je61DH1Hi+vVmLKtkguHZgaOnkKTI6EkLtPmoTx7wnSVcjhBdd/0pzpDHzyoRe uQ/m3G2cWv62nxIPE8eEYSKNWdrdrsihogX6pwBYUqcx1j3vwvgjgMHccduz0ZOWhurqyh v1fCSNIcim6VKT+EBQeYlw5QtagFHLYmpc92yHGW3Jr2PKf8MYfPiFgVwTIU9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690488778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=23t6kzSCt2YmMsqkNDZ9J38vQ1M/6lsjtbTCbTItChE=; b=DFcV+ZQ99yShVOdhHM9zw5N415IctaLO3mpFBZikA3MacndKSQFX5WDh1rnikLUOHXCQbq ZWT0xDMSciTrin9W16bFQd4oJAdSbR2i2oxdA2DoXCgJ8uXJvrWsE1/N0py6GOU0tnfQ3e s6x/GDN+UFsr/zN5UJW+SGY8Q9B8iWOYM6JcVcUHkP05LCpmiciuAi7/oyUdCzo7foX1cP /w3Eq0BdvHhhQCUnz/A85EOzB7DIh6ddR6/HYnfp+P5vDjDSLjwSHc2HwZcu+9PvRWGPHD Il55QKzdzG+W8qI+pROqeI3sgl6X5pTwiOTBUqoMTqvKcop2XRH3JhzG0F392A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690488778; a=rsa-sha256; cv=none; b=Ryck/iuehiJY3oTcbRZVbt5QU2Aawap/gs7rrnsZr6JHef3SW9D48fQH21Oy1mzOSlwpo7 tW/yFwBtaqytZgwMUzc3PVnenyKyfrVfeQz4qtH8DfNlQEeOF2gF79+KqRUNwEatEb2qJo UJnR8mSr2govLQG8/dyX1HRzgmOo5cHr3/P0oNpEGsvZpi5LVz0wFvcLt+013X6UTReh7c twdoP3XrwuIcDzSG8OTIsDapcnAdaD0PMpzVzaGny6zUHWKjoKvRDFql+WdpDl8caURQrb D/W2B3WbADTwvfDZdSUjm9/E5BdPtnq8IJMRS0ysqlU0lxRzgogspWuBbytenA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RBhlY5y4jzNX6; Thu, 27 Jul 2023 20:12:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 36RKCvfG087673; Thu, 27 Jul 2023 20:12:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 36RKCvX3087672; Thu, 27 Jul 2023 20:12:57 GMT (envelope-from git) Date: Thu, 27 Jul 2023 20:12:57 GMT Message-Id: <202307272012.36RKCvX3087672@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 640e5cb30405 - main - kmsan: Add a comment explaining why KMSAN doesn't shadow above KERNBASE List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 640e5cb30405e98d3888b22bb040485e8bf3b446 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=640e5cb30405e98d3888b22bb040485e8bf3b446 commit 640e5cb30405e98d3888b22bb040485e8bf3b446 Author: Mark Johnston AuthorDate: 2023-07-15 18:04:55 +0000 Commit: Mark Johnston CommitDate: 2023-07-27 20:01:58 +0000 kmsan: Add a comment explaining why KMSAN doesn't shadow above KERNBASE Sponsored by: The FreeBSD Foundation --- sys/amd64/include/msan.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/sys/amd64/include/msan.h b/sys/amd64/include/msan.h index 56460575ea7e..b62b3c243505 100644 --- a/sys/amd64/include/msan.h +++ b/sys/amd64/include/msan.h @@ -41,8 +41,9 @@ typedef uint32_t msan_orig_t; /* - * Our 32-bit origin cells encode a 2-bit type and 30-bit pointer. The pointer - * is compressed by making it a positive offset relative to KERNBASE. + * Our 32-bit origin cells encode a 2-bit type and 30-bit pointer to a kernel + * instruction. The pointer is compressed by making it a positive offset + * relative to KERNBASE. */ #define KMSAN_ORIG_TYPE_SHIFT 30u #define KMSAN_ORIG_PTR_MASK ((1u << KMSAN_ORIG_TYPE_SHIFT) - 1) @@ -76,6 +77,12 @@ kmsan_md_addr_to_orig(vm_offset_t addr) static inline bool kmsan_md_unsupported(vm_offset_t addr) { + /* + * The kernel itself isn't shadowed: for most purposes global variables + * are always initialized, and because KMSAN kernels are large + * (GENERIC-KMSAN is ~80MB at the time of writing), shadowing would + * incur signficant memory usage. + */ return (addr < VM_MIN_KERNEL_ADDRESS || addr >= KERNBASE); }