From owner-freebsd-bugs@FreeBSD.ORG Fri Jul 17 19:30:02 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EEF5B10656B8 for ; Fri, 17 Jul 2009 19:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B019C8FC2B for ; Fri, 17 Jul 2009 19:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6HJU220027612 for ; Fri, 17 Jul 2009 19:30:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6HJU2xm027611; Fri, 17 Jul 2009 19:30:02 GMT (envelope-from gnats) Resent-Date: Fri, 17 Jul 2009 19:30:02 GMT Resent-Message-Id: <200907171930.n6HJU2xm027611@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ruud Althuizen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 17720106564A for ; Fri, 17 Jul 2009 19:26:47 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 067D68FC0C for ; Fri, 17 Jul 2009 19:26:47 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n6HJQksX054312 for ; Fri, 17 Jul 2009 19:26:46 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n6HJQk2r054311; Fri, 17 Jul 2009 19:26:46 GMT (envelope-from nobody) Message-Id: <200907171926.n6HJQk2r054311@www.freebsd.org> Date: Fri, 17 Jul 2009 19:26:46 GMT From: Ruud Althuizen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/136875: _flags appending X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2009 19:30:03 -0000 >Number: 136875 >Category: misc >Synopsis: _flags appending >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Jul 17 19:30:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Ruud Althuizen >Release: 7.2-STABLE >Organization: >Environment: FreeBSD hyde.il.fontys.nl 7.2-STABLE FreeBSD 7.2-STABLE #0: Fri Jun 12 00:01:27 CEST 2009 root@hyde.il.fontys.nl:/usr/obj/usr/src/sys/HYDE i386 >Description: When configuring software in /etc/rc.conf I sometimes find that I want to append something to _flags instead of overwriting it. This may be the case for long lines or lines where the defaults are sensible but just missing stuff. For example in the mailgraph rc-script, the default is: : ${mailgraph_flags="--logfile /var/log/maillog --daemon-rrd=/var/db/mailgraph --ignore-localhost --daemon --daemon-pid=${mailgraph_pidfile}" I just want the '--rbl-is-spam' flag added. In this case another problem occurs, predefined variables are used (the pidfile). So that would mean I need to define both or define them in one go. >How-To-Repeat: >Fix: I propose to have /etc/rc.subr line 594 (eval rc_flags=\$${name}_flags) expanded to include something like \$${name}_flags_append >Release-Note: >Audit-Trail: >Unformatted: