From owner-freebsd-fs@FreeBSD.ORG  Sat Sep 12 19:30:08 2009
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D8EFA1065670
	for <freebsd-fs@hub.freebsd.org>; Sat, 12 Sep 2009 19:30:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id C8FE18FC23
	for <freebsd-fs@hub.freebsd.org>; Sat, 12 Sep 2009 19:30:08 +0000 (UTC)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n8CJU8SS059921
	for <freebsd-fs@freefall.freebsd.org>; Sat, 12 Sep 2009 19:30:08 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n8CJU8oJ059918;
	Sat, 12 Sep 2009 19:30:08 GMT (envelope-from gnats)
Date: Sat, 12 Sep 2009 19:30:08 GMT
Message-Id: <200909121930.n8CJU8oJ059918@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/132068: commit references a PR
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Sep 2009 19:30:08 -0000

The following reply was made to PR kern/132068; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/132068: commit references a PR
Date: Sat, 12 Sep 2009 19:28:07 +0000 (UTC)

 Author: pjd
 Date: Sat Sep 12 19:27:54 2009
 New Revision: 197131
 URL: http://svn.freebsd.org/changeset/base/197131
 
 Log:
   Tighten up the check for race in zfs_zget() - ZTOV(zp) can not only contain
   NULL, but also can point to dead vnode, take that into account.
   
   PR:		kern/132068
   Reported by:	Edward Fisk" <7ogcg7g02@sneakemail.com>, kris
   Fix based on patch from:	Jaakko Heinonen <jh@saunalahti.fi>
   MFC after:	1 week
 
 Modified:
   head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c
 
 Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c
 ==============================================================================
 --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c	Sat Sep 12 19:07:03 2009	(r197130)
 +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c	Sat Sep 12 19:27:54 2009	(r197131)
 @@ -890,8 +890,16 @@ again:
  		if (zp->z_unlinked) {
  			err = ENOENT;
  		} else {
 -			if (ZTOV(zp) != NULL)
 -				VN_HOLD(ZTOV(zp));
 +			if ((vp = ZTOV(zp)) != NULL) {
 +				VI_LOCK(vp);
 +				if ((vp->v_iflag & VI_DOOMED) != 0) {
 +					VI_UNLOCK(vp);
 +					vp = NULL;
 +				} else
 +					VI_UNLOCK(vp);
 +			}
 +			if (vp != NULL)
 +				VN_HOLD(vp);
  			else {
  				if (first) {
  					ZFS_LOG(1, "dying znode detected (zp=%p)", zp);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"