From owner-svn-src-head@freebsd.org Sat Jan 13 19:58:15 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 07868E7CAFD; Sat, 13 Jan 2018 19:58:15 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DAB1274C80; Sat, 13 Jan 2018 19:58:14 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (Seawolf.HML3.ScaleEngine.net [209.51.186.28]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 2CEE213771; Sat, 13 Jan 2018 19:58:07 +0000 (UTC) Subject: Re: svn commit: r327934 - head/sys/contrib/zstd/lib/freebsd To: "Pedro F. Giffuni" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801131809.w0DI9AZw072646@repo.freebsd.org> From: Allan Jude Message-ID: <63f8d491-edef-5b92-8b4c-04f64c15c847@freebsd.org> Date: Sat, 13 Jan 2018 14:58:06 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jan 2018 19:58:15 -0000 On 2018-01-13 14:23, Conrad Meyer wrote: > On Sat, Jan 13, 2018 at 10:09 AM, Pedro F. Giffuni wrote: >> Author: pfg >> Date: Sat Jan 13 18:09:09 2018 >> New Revision: 327934 >> URL: https://svnweb.freebsd.org/changeset/base/327934 >> >> Log: >> zstd: Use memalloc(9) for calloc macro. >> >> This is in contrib code but since we only have memalloc(9) in current we >> will not upstream this. > > Fortunately, zstd_kfreebsd.h is not contrib code but local code. We > don't have to worry about upstreaming this change. Please consider > including review from Allan Jude, Warner, or myself on future zstd > changes. We've tried to be very careful not to modify contrib code. > > For the record, though, I approve this change. > > Best, > Conrad > >> Modified: >> head/sys/contrib/zstd/lib/freebsd/zstd_kfreebsd.h > Looks good to me too -- Allan Jude