From owner-freebsd-testing@FreeBSD.ORG Mon Oct 28 23:50:35 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5B643BDB; Mon, 28 Oct 2013 23:50:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pb0-x22c.google.com (mail-pb0-x22c.google.com [IPv6:2607:f8b0:400e:c01::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 24812297F; Mon, 28 Oct 2013 23:50:35 +0000 (UTC) Received: by mail-pb0-f44.google.com with SMTP id rp16so2501551pbb.31 for ; Mon, 28 Oct 2013 16:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=uuObe4+TnnsPQzDXfYAOT1Ey6ResFk1bAU/mxqqgGSc=; b=RklW0tp2oFBYo7lNbt0/kCpS7dDJ5RfJ5Q3w5K18k62eJSfYQ9wNvr3ps0PGdJ9l/z eJgFLRg1OUWtULXAe+noc356jYQ+dXSLBJYzgLlq83KdFS9PCxk/OdUeKOSW3Qci2YMN nSLnTb1VI9W4EbOjt/F9tW+OU5XIsy0vqO1o6ulzMuRwrAr3jZd0nsaFcXC2x0SE2qD8 aSKh6PIrmwMsDGSqiX6f4XfCWgK5hGeDnsFFT5pu/Elhb9VzKHjOJUfhI5n/4NsYQPVB oZlcuo90QhxneCCAhP7qfHAUrWoCOWUxhCHohJ6DPIneWeaul4szGeGKHzwlKtBR+4/W FF7w== X-Received: by 10.68.179.4 with SMTP id dc4mr9217427pbc.45.1383004234730; Mon, 28 Oct 2013 16:50:34 -0700 (PDT) Received: from [10.0.1.195] ([64.14.143.130]) by mx.google.com with ESMTPSA id ho3sm31120922pbb.23.2013.10.28.16.50.33 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 28 Oct 2013 16:50:34 -0700 (PDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: Plugging ATF tests into the build and other cleanups From: Garrett Cooper In-Reply-To: Date: Mon, 28 Oct 2013 16:51:28 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Alan Somers X-Mailer: Apple Mail (2.1510) Cc: "freebsd-testing@freebsd.org" , Rui Paulo , Simon Gerraty X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Oct 2013 23:50:35 -0000 On Oct 28, 2013, at 8:47 AM, Alan Somers wrote: > On Sun, Oct 27, 2013 at 7:31 PM, Julio Merino wrote: >> On Sun, Oct 27, 2013 at 8:25 PM, Eitan Adler = wrote: >>> On Sun, Oct 27, 2013 at 6:12 PM, Julio Merino = wrote: >>>> Hello! >>>> The one concern I have here is having to keep track of all tests in >>>> tools/build/mk/OptionalObsoleteFiles.inc so that setting >>>> WITHOUT_TESTS=3Dno cleans up /usr/tests. This will be a pain to = maintain >>>> and a sure source of inconsistencies. If we could special-case this = to >>>> make it more automatic, do you have any suggestions? >>>=20 >>> Is it possible to use the list of current tests and just delete any >>> files which are not listed? >>=20 >> I think what you are suggesting applies to src/ObsoleteFiles.inc, not >> tools/build/mk/OptionalObsoleteFiles.inc? >>=20 >> For deleted tests, I think using src/ObsoleteFiles.inc is fine as >> usual. Deleted tests have to be removed no matter what the value of >> MK_TESTS is. If that list gets out of hand at some point we could >> revisit this, although I'm not sure how you can easily determine the >> list of "current tests". AFAIK there is no list in src detailing all >> files that are expected to be installed? >>=20 >> My concern is only about the latter at the moment. When MK_TESTS=3Dno, >> /usr/tests should not exist at all and, therefore, a "make >> delete-old-files" should wipe it. We can do this as usual, with the >> functionality in tools/build/mk/OptionalObsoleteFiles.inc to record >> all files to be deleted, or we can do something different to avoid >> maintaining the list by hand. A simple "rm -rf ${DESTDIR}/usr/tests" >> would suffice, but I'm just wondering if that'd be an acceptable = thing >> to do. >>=20 >>> We would need some way to have "local" tests but that should not be = difficult? >>=20 >> You mean tests from ports and/or for manually installed software? >> Those should all be somewhere in /usr/local/ and we can easily hook >> them into the test suite. (Hadn't thought about these, but it's >> easy.) >=20 > On our custom version of FreeBSD, we have a few ports that install > tests to /usr/local/tests, a top-level Kyuafile at both > /usr/tests/Kyuafile and /usr/local/tests/Kyuafile, and a symlink from > /usr/tests/local -> /usr/local/tests. It works well. It would be nice if this was standardized and documented like with gcc = for instance with its debug lookup paths=85 Thanks! -Garrett=