From owner-freebsd-fs@FreeBSD.ORG Thu Aug 25 21:06:44 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8EE081065670 for ; Thu, 25 Aug 2011 21:06:44 +0000 (UTC) (envelope-from freebsd-fs@m.gmane.org) Received: from lo.gmane.org (lo.gmane.org [80.91.229.12]) by mx1.freebsd.org (Postfix) with ESMTP id 8079D8FC12 for ; Thu, 25 Aug 2011 21:06:35 +0000 (UTC) Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Qwh8B-0006Br-ES for freebsd-fs@freebsd.org; Thu, 25 Aug 2011 23:06:31 +0200 Received: from 208.88.188.90.adsl.tomsknet.ru ([90.188.88.208]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 25 Aug 2011 23:06:31 +0200 Received: from vadim_nuclight by 208.88.188.90.adsl.tomsknet.ru with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 25 Aug 2011 23:06:31 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: freebsd-fs@freebsd.org From: Vadim Goncharov Date: Thu, 25 Aug 2011 21:06:18 +0000 (UTC) Organization: Nuclear Lightning @ Tomsk, TPU AVTF Hostel Lines: 28 Message-ID: References: <1092971110.92110.1313782831745.JavaMail.root@erie.cs.uoguelph.ca> <20110820145112.Y872@besplex.bde.org> <20110824015751.I2167@besplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 208.88.188.90.adsl.tomsknet.ru X-Comment-To: Bruce Evans User-Agent: slrn/0.9.9p1 (FreeBSD) Subject: Re: touch(1) not working on directories in an msdosfs(5) envirement X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: vadim_nuclight@mail.ru List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2011 21:06:44 -0000 Hi Bruce Evans! On Wed, 24 Aug 2011 02:19:56 +1000 (EST); Bruce Evans wrote about 'Re: touch(1) not working on directories in an msdosfs(5) envirement': >>> The above is only the least serious of the bugs in msdosfs_setattr() :-(. >>> With the above fix, plain touch works as well as possible -- it cannot >>> work perfectly since setting of atimes is not always supported. But >>> touch -r and more importantly, cp -p only work as well as possible for >>> root, since they use utimes() without the null timeptr arg that allows >>> plain touch to work. A non-null timeptr arg ends up normally requiring >>> root permissions for msdosfs where it normally doesn't require extra >>> permissions for ffs, because ownership requirements for the non-null case >>> cannot be satisfied by file systems that don't really support ownerships. >>> We fudge the ownerships and use weak checks on them in most places, but >>> for utimes() we use strict checks that almost always fail: from my old >>> version: >> >> So, now the usual case of not touching directory times on change is preserved, >> but cp -r et al. sets times as expected? Sounds good, could it be committed >> please? > Yes, cp -p works but only if the user is root or the owner of the file. > Someone else will have to commit it. Umm... but why not you?.. -- WBR, Vadim Goncharov. ICQ#166852181 mailto:vadim_nuclight@mail.ru [Anti-Greenpeace][Sober FreeBSD zealot][http://nuclight.livejournal.com]