Date: Sat, 24 Oct 2009 14:47:47 +0200 (CEST) From: Tijl Coosemans <tijl@ulyssis.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/139884: audio/akode: fix dependency on libltdl Message-ID: <200910241247.n9OCllGp064764@kalimero.kotnet.org> Resent-Message-ID: <200910241300.n9OD0E7R044665@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 139884
>Category: ports
>Synopsis: audio/akode: fix dependency on libltdl
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Oct 24 13:00:13 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Tijl Coosemans
>Release: FreeBSD 7.2-STABLE i386
>Organization:
>Environment:
>Description:
In the audio/akode Makefile the USE_AUTOTOOLS variable is assigned twice
thereby erasing the dependency on libltdl.
>How-To-Repeat:
>Fix:
The first patch fixes the USE_AUTOTOOLS assignment.
The second patch is an attempt to simplify the Makefile and fix
some portlint warnings.
--- patch-akode begins here ---
--- Makefile.orig 2009-10-24 13:07:24.000000000 +0200
+++ Makefile 2009-10-24 13:42:07.000000000 +0200
@@ -7,6 +7,7 @@
PORTNAME= akode
PORTVERSION= 2.0.2
+PORTREVISION= 1
PORTEPOCH= 1
CATEGORIES= audio kde
MASTER_SITES= ${MASTER_SITE_GENTOO}
@@ -27,8 +28,7 @@
RESAMPLER "Resampler processing plugin" on \
XIPH "FLAC/Speex/Vorbis decoder plugin" on
-USE_AUTOTOOLS= libltdl
-USE_AUTOTOOLS= libtool:22
+USE_AUTOTOOLS= libtool:22 libltdl
USE_BZIP2= yes
USE_GMAKE= yes
WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
--- patch-akode ends here ---
--- patch-akode2 begins here ---
--- Makefile.orig 2009-10-24 13:43:00.000000000 +0200
+++ Makefile 2009-10-24 14:21:55.000000000 +0200
@@ -12,8 +12,7 @@
CATEGORIES= audio kde
MASTER_SITES= ${MASTER_SITE_GENTOO}
MASTER_SITE_SUBDIR=distfiles
-DISTNAME= 30375-${PORTNAME}-${PORTVERSION}.tar.bz2
-EXTRACT_SUFX= # none
+DISTFILES= 30375-${DISTNAME}${EXTRACT_SUFX}
MAINTAINER= kde@FreeBSD.org
COMMENT= Default KDE audio backend
@@ -31,7 +30,6 @@
USE_AUTOTOOLS= libtool:22 libltdl
USE_BZIP2= yes
USE_GMAKE= yes
-WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION}
USE_LDCONFIG= yes
PLIST_SUB+= MACHINE_ARCH=${MACHINE_ARCH}
@@ -39,10 +37,10 @@
--with-extra-libs=${LOCALBASE}/lib \
--with-extra-includes=${LOCALBASE}/include
-.include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
.if defined(WITH_FFMPEG)
-RUN_DEPENDS= ${LOCALBASE}/lib/libakode_ffmpeg_decoder.so:${PORTSDIR}/audio/akode-plugins-ffmpeg
+RUN_DEPENDS+= ${LOCALBASE}/lib/libakode_ffmpeg_decoder.so:${PORTSDIR}/audio/akode-plugins-ffmpeg
.endif
.if defined(WITH_JACK)
@@ -76,10 +74,4 @@
$$(all_libraries) ${PTHREAD_LIBS}|g' \
${WRKSRC}/akode/akodeplay/Makefile.in
-do-build:
- cd ${WRKSRC}/akode && ${GMAKE}
-
-do-install:
- cd ${WRKSRC}/akode && ${GMAKE} install
-
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
--- patch-akode2 ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200910241247.n9OCllGp064764>