From owner-svn-ports-head@freebsd.org Tue Jan 29 15:23:09 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3AF8414C0C80; Tue, 29 Jan 2019 15:23:09 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D4C718B2B7; Tue, 29 Jan 2019 15:23:08 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 7EB8B10087; Tue, 29 Jan 2019 15:23:08 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from ogg.in.absolight.net (ogg.in.absolight.net [IPv6:2a01:678:ab:50::42:42]) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 09A41943CFD; Tue, 29 Jan 2019 15:23:07 +0000 (UTC) Date: Tue, 29 Jan 2019 16:23:06 +0100 From: Mathieu Arnold To: John Hixson Cc: Ruslan Makhmatkhanov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r491567 - in head/net: . py-ifaddr Message-ID: <20190129152306.ao7svko2lipihsqo@ogg.in.absolight.net> References: <201901291452.x0TEq8I7021248@repo.freebsd.org> <2964250e-028e-ec9c-d1c6-f1b7afea6487@yandex.ru> <20190129150558.GD83860@pcbsd.divinix.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pprgdttmjq6lcfon" Content-Disposition: inline In-Reply-To: <20190129150558.GD83860@pcbsd.divinix.org> User-Agent: NeoMutt/20180622 X-Rspamd-Queue-Id: D4C718B2B7 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 15:23:09 -0000 --pprgdttmjq6lcfon Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 29, 2019 at 07:05:59AM -0800, John Hixson wrote: > On Tue, Jan 29, 2019 at 06:02:08PM +0300, Ruslan Makhmatkhanov wrote: > > Hi John, > >=20 > > John Hixson wrote on 1/29/19 5:52 PM: > > > Author: jhixson > > > Date: Tue Jan 29 14:52:08 2019 > > > New Revision: 491567 > > > URL: https://svnweb.freebsd.org/changeset/ports/491567 > > >=20 > > > Log: > > > [New port] net/py-ifaddr: Python library to enumerate all network = interfaces > > > =20 > > > Approved by: araujo (mentor), miwi (mentor) > > > Differential Revision: https://reviews.freebsd.org/D19013 > > >=20 > > > Added: > > > head/net/py-ifaddr/ > > > head/net/py-ifaddr/Makefile (contents, props changed) > > > head/net/py-ifaddr/distinfo (contents, props changed) > > > head/net/py-ifaddr/pkg-descr (contents, props changed) > > > Modified: > > > head/net/Makefile > >=20 > > [...] > >=20 > > >=20 > > > Added: head/net/py-ifaddr/Makefile > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > > +++ head/net/py-ifaddr/Makefile Tue Jan 29 14:52:08 2019 (r491567) > > > @@ -0,0 +1,27 @@ > > > +# Created by: John Hixson > > > +# $FreeBSD$ > > > + > > > +PORTNAME=3D ifaddr > > > +PORTVERSION=3D 0.1.6 > > > +CATEGORIES=3D net python > > > +PKGNAMEPREFIX=3D ${PYTHON_PKGNAMEPREFIX} > > > + > > > +MAINTAINER=3D jhixson@FreeBSD.org > > > +COMMENT=3D Python Library to enumerate all network interfaces > > > + > > > +LICENSE=3D MIT > > > + > > > +USES=3D python:2.7+ > > > + > > > +USE_PYTHON=3D autoplist distutils > > > + > > > +USE_GITHUB=3D yes > > > +GH_ACCOUNT=3D pydron > > > + > >=20 > > [...] > >=20 > > > +.include > > > + > > > +.if ${PYTHON_MAJOR_VER} < 3 > > > +RUN_DEPENDS=3D ${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/py-ipaddress > > > +.endif > > > + > > > +.include > >=20 > > You may change this with adding uncoditionally > >=20 > > RUN_DEPENDS=3D ${PY_IPADDRESS} > >=20 > > because in Mk/Uses/python.mk we have: > >=20 > > .if ${PYTHON_REL} < 3300 > > PY_IPADDRESS=3D=20 > > ${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/py-ipaddress@${PY_FLAVOR} > > .else > > PY_IPADDRESS=3D > > .endif > > } > >=20 > > It doing the same, but looking better IMHO :) >=20 > I agree. Thanks for the tip. I'll get this in as soon as I can. Funnily, it is also documented: https://www.freebsd.org/doc/en/books/porters-handbook/using-python.html#usi= ng-python-variables-helpers --=20 Mathieu Arnold --pprgdttmjq6lcfon Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlxQb9pfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkg0Nw//WCZLsTOUfNOxYqL1daRjjXEfULSTbue4x7C4Ow6cFq5K4ynkjf8Po6dQ nyeBLA+XjOI1ObMTFGN7hFbnpxxVxSPeqeDkG4ugf7En593noKOGq/pk/TzdzTb2 HPOHEA8oddUmBFgJOZlwJ57cemwyuqzrhdM5rO//9IrJ5iqYjmJOpkoIfArdOGKE EnYd4HwHiqkoZFi8fyl4rO9i8pB71of5IykvlA8cHTN8T+jqPBBRcCZvaBXxuAAS VKoYvu4cas7DQUHp1zWj97+2BNQUvIZheKFNBs6Q6z+K4Ctq/OFA1MeSzohAykwA FO3pPHOEAphNwkPUlhvazO25p8ORXLRTYEQASNscdI1+GpxK8Oqzm0SgG2xJEmfG VJEW52GJ6Ma43y/0MDvjjnk+YhXe9mGotYTU35+VmAwtm2ZMSg9JNiiyDq/Dyyxm kv5BLIiYv7jheK88DQelPOuPPrmzo0EZ9gHQ8JXX5QGr1MKWRQgWEe/pPXx54ZWu oAv6HdX+grh9wiPIlMTfDsUOuyJETvJxV68G4sFFzgXhH1n3rVyqkw6ubqsEfVfM /PgK+gDaUxqALacTSmJaBRtgSm+I8Ni6k51i0NhThhhvgumVh/plWEYWDuLxdGhJ qlsFVMDhrA294X2gunnwSzaQ/6kW8pTllulo/rJUcUS0B9fm/DE= =URzU -----END PGP SIGNATURE----- --pprgdttmjq6lcfon--