From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Jun 8 19:40:01 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CE5B51065673 for ; Tue, 8 Jun 2010 19:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (unknown [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A8AF78FC0A for ; Tue, 8 Jun 2010 19:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o58Je05p030224 for ; Tue, 8 Jun 2010 19:40:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o58Je01C030223; Tue, 8 Jun 2010 19:40:00 GMT (envelope-from gnats) Resent-Date: Tue, 8 Jun 2010 19:40:00 GMT Resent-Message-Id: <201006081940.o58Je01C030223@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Nathan Whitehorn Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BACF0106566B for ; Tue, 8 Jun 2010 19:31:50 +0000 (UTC) (envelope-from nwhitehorn@anacreon.physics.wisc.edu) Received: from anacreon.physics.wisc.edu (anacreon.physics.wisc.edu [128.104.160.176]) by mx1.freebsd.org (Postfix) with ESMTP id 6CB1A8FC19 for ; Tue, 8 Jun 2010 19:31:50 +0000 (UTC) Received: from anacreon.physics.wisc.edu (localhost [127.0.0.1]) by anacreon.physics.wisc.edu (8.14.4/8.14.4) with ESMTP id o58JVnSv032751 for ; Tue, 8 Jun 2010 14:31:49 -0500 (CDT) (envelope-from nwhitehorn@anacreon.physics.wisc.edu) Received: (from nwhitehorn@localhost) by anacreon.physics.wisc.edu (8.14.4/8.14.4/Submit) id o58JVnxA032750; Tue, 8 Jun 2010 14:31:49 -0500 (CDT) (envelope-from nwhitehorn) Message-Id: <201006081931.o58JVnxA032750@anacreon.physics.wisc.edu> Date: Tue, 8 Jun 2010 14:31:49 -0500 (CDT) From: Nathan Whitehorn To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/147699: [patch] powerpc64 support for x11-toolkits/gtk20 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Nathan Whitehorn List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2010 19:40:02 -0000 >Number: 147699 >Category: ports >Synopsis: [patch] powerpc64 support for x11-toolkits/gtk20 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Jun 08 19:40:00 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Nathan Whitehorn >Release: FreeBSD 9.0-CURRENT powerpc64 >Organization: University of Wisconsin >Environment: System: FreeBSD anacreon.physics.wisc.edu 9.0-CURRENT FreeBSD 9.0-CURRENT #3 r208870:208872: Sun Jun 6 09:33:03 CDT 2010 root@anacreon.physics.wisc.edu:/usr/obj/scratch/src/sys/ANACREON powerpc64 >Description: Due to a flaw in binutils 2.15, function names can conflict with ELF assembler directives on PPC64 systems. As a result, it is not possible to have functions named things like 'text' and 'data', one of which GTK 2.0 has. >How-To-Repeat: Build GTK 2 on powerpc64. >Fix: This patches renames a private function in gtkbuilderparser.c from text to XXXtext on powerpc64 systems to work around the ABI problem with binutils. --- gtk20-ppc64.diff begins here --- --- Makefile.bak 2010-06-08 14:13:17.000000000 -0500 +++ Makefile 2010-06-08 14:15:03.000000000 -0500 @@ -61,6 +61,14 @@ CONFIGURE_ARGS+= --enable-debug=yes .endif +.if !defined(ARCH) +ARCH!= /usr/bin/uname -p +.endif + +.if ${ARCH} == powerpc64 +EXTRA_PATCHES= ${.CURDIR}/files/extra-arch-powerpc64 +.endif + .include .if (defined(WITH_CUPS) || exists(${LOCALBASE}/lib/libcups.so)) && \ --- /dev/null 2010-06-08 14:26:55.000000000 -0500 +++ files/extra-arch-powerpc64 2010-06-08 14:15:47.000000000 -0500 @@ -0,0 +1,20 @@ +--- gtk/gtkbuilderparser.c.dist 2010-06-08 14:11:06.000000000 -0500 ++++ gtk/gtkbuilderparser.c 2010-06-08 14:11:33.000000000 -0500 +@@ -1051,7 +1051,7 @@ + /* Called for character data */ + /* text is not nul-terminated */ + static void +-text (GMarkupParseContext *context, ++XXXtext (GMarkupParseContext *context, + const gchar *text, + gsize text_len, + gpointer user_data, +@@ -1106,7 +1106,7 @@ + static const GMarkupParser parser = { + start_element, + end_element, +- text, ++ XXXtext, + NULL, + NULL + }; --- gtk20-ppc64.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: