From nobody Fri Apr 24 16:24:43 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g2JFm2xLzz6bXVc for ; Fri, 24 Apr 2026 16:24:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g2JFl71YNz3bB7 for ; Fri, 24 Apr 2026 16:24:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777047884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+4xaav7RRR+M6QRodXbGPZymw3ELd8MR7smbS8eZs5U=; b=lmop0wLhy7tPNJhVmNBcwN30e4vlyspXUXxExTfDu+KBiUZk+otDBJLhIy2+ONdSn90M5k 26rZCTyI53SHrEVR9xlMUH41L57LbObCGJHTEx+SG7Ol7JAzIEaYTDKpTK5/NBXP9bOIB6 /OoKU/1Wm2I8BiBM/HUEOE7+nRBtqiSa8OVyqHNdlkuAYubn6mqn7JKpCdn30DYw52qxCb i+kNw9QFZ3MBpvti4c3fog49IZ85LMt02ojnFvamw3pSygIZUWMbTtxh2MJ92PR406SEl+ tjSl73k5k1SnzxTwq+dPUvuSL+ZRpDK6f8EQv/v3+QAi7/HoCiX0vSvbu9bp8Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777047884; a=rsa-sha256; cv=none; b=qSV1nDZ4PPT8X0GGX9VTmgVlPf8NpM7nqs1g+5MLrAcctQHrYDXblJH5CKy8imZgUVjqTk n9r/mZnsGVk7lH6dMkXfpEZAPjif9J3xP7pDxHRYB/nr5lzSlNwL/dVl5YWc46nAELQF9f zIPOUdqZgOe7PwaCtg50nVXgvBaBK+0W3Q8NzE69OjsgqHqFlsqaeL1WVXOPDrU1g7NaJd V+dXcxVUVSK95MhYxMxfrxoh10JwHLlD/43rOAnTg/8BtVrM7WYMXkVdLNuEJPJY2+ufvU 0MtC0P4QX+hs7kCmEx7DshglgO/LpU2vwb2LGDWud0s+VIYEwbm8x/+atpyz9Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777047884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+4xaav7RRR+M6QRodXbGPZymw3ELd8MR7smbS8eZs5U=; b=uJc1EyyNvRJSX0yJjrJK0jGylhmfid9gWfXFNzB3z/OofbLlRsU3KwW9iYqfqUS6Ia62UE kMWCePSO+hVCXGfjiK3JcPUC14Av37fJ0kTVMN1Ao7bwLycdNuuhIZykoVgc2Fmly9cBuv c+wC5cimF6FIljN2JORsm4RfH3T6HLUNwa6e+tx3d1Nqt+F2rkBNIoV2bt0sX43CpiKAc3 XQlOp//GVIMfDw/Sn3X+2w2hMZ0/GCEFYFvd/A8PA07XOCa3Iz8yKbqlFBaa3CWL8wRBKG oHWArWiC8PsMUSi2gJe++gpUKm0n+V6/zdmZ7yHLucrLubC2dLezyas4nxsdng== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g2JFl6RQsz18tZ for ; Fri, 24 Apr 2026 16:24:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3aecd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 24 Apr 2026 16:24:43 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Raphael Poss From: Warner Losh Subject: git: 43b7cf42d425 - main - speaker(4): drop NEEDGIANT List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 43b7cf42d425abc84a1313b7eed933438804a051 Auto-Submitted: auto-generated Date: Fri, 24 Apr 2026 16:24:43 +0000 Message-Id: <69eb994b.3aecd.383c3505@gitrepo.freebsd.org> The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=43b7cf42d425abc84a1313b7eed933438804a051 commit 43b7cf42d425abc84a1313b7eed933438804a051 Author: Raphael Poss AuthorDate: 2025-12-10 20:12:22 +0000 Commit: Warner Losh CommitDate: 2026-04-24 16:23:06 +0000 speaker(4): drop NEEDGIANT When the frequency configuration logic was moved to clock.c in 2008, a mutex lock was added there (timer_spkr_setfreq) to serialize accesses to the I/O register. Since then, no more calls to disable/enable_intr were needed in spkr.c than they were needed in the other callers to the same timer_spkr functions in syscons / kern_cons, that is, not at all. This is because there are no other accesses remaining in the kernel to the i8254 timers after boot than through clock.c. For context, see commits e46598588587b4897f6604489364f83fffd4d033 and 93f5134aaf829826dbcbea457bfeb27389761854. Signed-off-by: Raphael Poss Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1922 --- sys/dev/speaker/spkr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/dev/speaker/spkr.c b/sys/dev/speaker/spkr.c index 2cdbbd43ff6e..85789c107336 100644 --- a/sys/dev/speaker/spkr.c +++ b/sys/dev/speaker/spkr.c @@ -24,7 +24,7 @@ static d_ioctl_t spkrioctl; static struct cdevsw spkr_cdevsw = { .d_version = D_VERSION, - .d_flags = D_NEEDGIANT, + .d_flags = 0, .d_open = spkropen, .d_close = spkrclose, .d_write = spkrwrite, @@ -78,10 +78,8 @@ tone(unsigned int thz, unsigned int centisecs) if (timer_spkr_acquire()) { return; } - disable_intr(); /* Configure the speaker with the tone frequency. */ timer_spkr_setfreq(thz); - enable_intr(); /* * Make the current thread sleep while the tone is being