From owner-freebsd-arch@FreeBSD.ORG Tue Sep 21 23:22:33 2004 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0C0FF16A4CE; Tue, 21 Sep 2004 23:22:33 +0000 (GMT) Received: from athena.softcardsystems.com (mail.softcardsystems.com [12.34.136.114]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF71943D2D; Tue, 21 Sep 2004 23:22:32 +0000 (GMT) (envelope-from sah@softcardsystems.com) Received: from athena (athena [12.34.136.114])i8M0LxE4003290; Tue, 21 Sep 2004 19:21:59 -0500 Date: Tue, 21 Sep 2004 19:21:59 -0500 (EST) From: Sam X-X-Sender: sah@athena To: Julian Elischer In-Reply-To: <4150B03F.4070207@elischer.org> Message-ID: References: <415083CC.7C041DFD@freebsd.org><41508827.8010007@elischer.org> <41508FEB.6030203@elischer.org><4150B03F.4070207@elischer.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed cc: Andre Oppermann cc: freebsd-arch@freebsd.org Subject: Re: AoE for 4.x X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2004 23:22:33 -0000 > Sam wrote: > >>> >>> >>> I guess we are used to it. >>> >>> I can't recommend enough the utility of having a cvs mirror and using cvs >>> to keep your >>> work trees sync'd against FreeBSD. It is also a goodd way of making sure >>> that you don't >>> forget parts of the diff (e.g. Makefiles etc.) as CVS will pick up all the >>> changed files. >>> >> >> And I can't thank you enough. I forgot about a few other (rather) >> important file changes this picked up. >> >> A patchfile for aoe against today's 4.10 source tree >> is at: >> http://www.coraid.com/support/freebsd/aoe.patch >> >> A few notes: >> >> The file sys/dev/aoe/aoe4bsd.dd is basic documentation for >> the driver. >> >> All references to chr major 200 will have to be changed to whatever >> gets assigned, obviously. >> >> The netisr selected in sys/net/netisr.h was picked at random. Is it >> OK? >> >> The label typeunknown in sys/net/if_ethersubr.c is added to give >> netgraph a chance to get the packets if AoE is not loaded. Appropriate? >> >> I dinna know how to fill out the copyright/license comment in the headers, >> but i gave it a shot. Thoughts here would be appreciated. >> >> TIA to all the curious eyes that skim the driver for glaring flaws. > > haven't read it yet, just skimmed.. > > Very CLEAN looking code.. style(9) complient to a large extent.. > (you do know about 'man 9 style' right?) Thanks - I didn't, but I do now. :) > now that it is written, this is the time to > go through it and write down everything that comes to mind in comments.. > Everything that a person trying to decode the driver might want to know. > Including comments about the standards, tricky bits of code, > reasons you decided to do things in certain ways. etc. I tend towards the side that says you write a short paper about a chunk of code as comments can (and do) get out of sync. When in Rome, though ... I'll have to digest the style page a little more to see what types of comments are requested. I'm choking a bit on some of the other requirements. Sam