From nobody Tue Feb 10 15:33:08 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f9QYw6Xr3z6RW39 for ; Tue, 10 Feb 2026 15:33:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f9QYw5hP4z3Ggm for ; Tue, 10 Feb 2026 15:33:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770737588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eIrFzy/+N6UpnWFqpWR5pLuHo0YPUtFUZNnEnRjEw54=; b=opI6SEH3SeqdqDMGTmuiwmNz9zyp6eRh9XdhxIkm4JsPO0AK4dOVrqt1SZuz+IYH/R42U8 I2FS6ExwrCdqoGYLptrOxfECnHkXCP/oQDWQfXyBWGCSoj7f2xDKMaCvIs2EuZyrFXBWf3 GnhbVoEVbszeNW4jX7W+qexsTEFSbHp8C+htWLpJs0Lk6eDmvM5HITCLNLdODDunzseHF+ SAeSwGM8MNzXTd5cKYYGzDOQYX7zPhX0spOvj3dUhFrJK07LwFrZqY+JWgl9xwKF0rjsMc YZR7OshYyyQ/tTCRhH7le9kXDXOg/y/pncZwhGQkkoAAW/pYKEwbmyAwIcXkIA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770737588; a=rsa-sha256; cv=none; b=aE/Zs3ioCdaB+Jn+IcJgeWTzh8xC5ZkN0pb/4T5p7FC2wehzX6jBTBUlJ07VHeAMIlxrT2 +fgi8qIvNwyUEv3KhKr/vCQ43IxDfgFWXGwuD5cOTXazTG5dqOrApHRzELGQanEa605/qo 3x6wdrZVvVezbgy+A9+S5C2L6UD5tZ4D0TWUQ5MQlyw/Bkxs29DESyKd7Z8Y9ttmrX9eRs DVsEF6pBSQyAS64r4dygfqVZOTHucDhMT8VX7xO8Ws7hZiAJgUG8SHpqE91/5TE2Zy6fzD b1jZ8PO04qK03avAsy54etyEwJZBThwdpolfcTSh0N9twOVDhg0nbfWVQx522Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770737588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eIrFzy/+N6UpnWFqpWR5pLuHo0YPUtFUZNnEnRjEw54=; b=YekC4jVaeSx5fKVqeC8OUGVq5aDT11jlY1DikWOUkFPyKyqv8eokYy/jtllpjbdD749Lw3 zmw4Ydk0sx6A5OKgFTE+NiIWHwA1n0lEmGz9r4JxeMSU/A3uyxjs7QaTHocqvP8lCw2cGo 1T6xzGVEugxTXQ/V8iTQLnst2K4hkahMBMOwglifBbWkXVgVbe0qxPLB5viwsxsKRBygVt 5wrR3VuDvROM+planVGTuklPCirALf5Mnw7l8j/XGFQISrz0S2J+OYXd6yJGZsvca1h6XA 5nMaMqsZhY6EnndkRnUS5cZkTmT5mJIb4F3btXHJh40Q4wZwwLnYrITrYH2i+Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f9QYw3PSBz1NbY for ; Tue, 10 Feb 2026 15:33:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 47176 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Feb 2026 15:33:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: f0852209a086 - stable/13 - diff: Add test case for pagination resource leak List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: f0852209a086387d8171da58a09faadaf5b0a455 Auto-Submitted: auto-generated Date: Tue, 10 Feb 2026 15:33:08 +0000 Message-Id: <698b4fb4.47176.21bc99b0@gitrepo.freebsd.org> The branch stable/13 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=f0852209a086387d8171da58a09faadaf5b0a455 commit f0852209a086387d8171da58a09faadaf5b0a455 Author: Dag-Erling Smørgrav AuthorDate: 2026-02-05 14:39:47 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-10 15:32:47 +0000 diff: Add test case for pagination resource leak The pagination code leaks either processes or descriptors or both, depending on the exact version of the code you have. Add a test case which exercises this leak to facilitate fixing it. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: thj, kevans Differential Revision: https://reviews.freebsd.org/D55111 (cherry picked from commit 270492602b9bd8b8fce4f021f055804978bf3f23) --- usr.bin/diff/tests/diff_test.sh | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/usr.bin/diff/tests/diff_test.sh b/usr.bin/diff/tests/diff_test.sh index 8b8846925ee8..181463ca9be7 100755 --- a/usr.bin/diff/tests/diff_test.sh +++ b/usr.bin/diff/tests/diff_test.sh @@ -328,6 +328,26 @@ bigu_body() diff -U$(((1<<31)-2)) a b } +prleak_head() +{ + atf_set "descr" "Verify that pagination does not leak resources" +} +prleak_body() +{ + local n=32 + mkdir a b + for hi in $(jot -w%02x $n 0) ; do + mkdir a/$hi b/$hi + for lo in $(jot -w%02x $n 0) ; do + echo "$hi$lo" >a/$hi/$lo + echo "$hi$lo" >b/$hi/$lo + done + done + ulimit -n 1000 + ulimit -u 1000 + atf_check diff -rul a b +} + atf_init_test_cases() { atf_add_test_case simple @@ -353,4 +373,5 @@ atf_init_test_cases() atf_add_test_case dirloop atf_add_test_case bigc atf_add_test_case bigu + atf_add_test_case prleak }