From owner-svn-src-all@FreeBSD.ORG Sun Sep 16 16:06:12 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 58C5D106564A for ; Sun, 16 Sep 2012 16:06:12 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 1E8C58FC0C for ; Sun, 16 Sep 2012 16:06:12 +0000 (UTC) Received: by pbbrp2 with SMTP id rp2so8565593pbb.13 for ; Sun, 16 Sep 2012 09:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=QAI+qv46z2LVY2EEXRQ8ZYLM4whKsP1pnMHkHh0T+GM=; b=C7hBqH7d3ivETlQYmVV4Vi1RViu5n5aKXHULgEnmqAASKlaKCQjvPZ+AZJFkdVUc6t pFHc4UXOvr3E0liae4MohHxURqn+o1M4egpapfPBeESaOk9v4pnmSl5XDpQ0AHjf4B5D oBjK+O6yHHUSVBmHxAadtqbKxfWTu/oKzJbuk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=QAI+qv46z2LVY2EEXRQ8ZYLM4whKsP1pnMHkHh0T+GM=; b=asE9JItNwJ6nMDodKIfxUZtWyYGuSuiHotn3mcGOWNYrni5svFTBnQkppwIhdFPLWy Eq1btrR9XdzvJUs4JM74rZtBihfzQERB2VtrTApffwqCmCi2hgfhhl1FZUbh9ZdD8RNS vzNhB4JLUQLz4pp5Dd2sHG12zn2/xcuAdrKinjXJ+Rz1Z3iYh0jpOmEU926oGB0Lw9wy Rj4tVJyQWQ1wd47EhcVvMChX9lDY88b6w4c/ew9Ily8fExA6S4J8hB7xAfEw44+t4GIX wG0wG9Wuiqsx+2EMG78PmboOVlZEGbpj2znHuJ12X+7GtTpg6gz8OQey7KxZDV96OuSp wQIA== Received: by 10.68.210.207 with SMTP id mw15mr123048pbc.81.1347811571801; Sun, 16 Sep 2012 09:06:11 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.66.87.41 with HTTP; Sun, 16 Sep 2012 09:05:41 -0700 (PDT) In-Reply-To: <5055E121.2030208@coosemans.org> References: <201209142347.q8ENlN7N034951@svn.freebsd.org> <5054EBCB.6070105@coosemans.org> <5054F116.8090503@cran.org.uk> <5055E121.2030208@coosemans.org> From: Eitan Adler Date: Sun, 16 Sep 2012 12:05:41 -0400 X-Google-Sender-Auth: 1uxuEuBFkE9yU7Rwb09DhC4HenE Message-ID: To: Tijl Coosemans Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmsz0yNvvTnUUXyBLo1iA2OkrE03JzkpNv51QTTt1rIIc6wku4sxk90T8oAz3nNb8IcO14A Cc: Bruce Cran , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240527 - head/bin/df X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Sep 2012 16:06:12 -0000 On 16 September 2012 10:24, Tijl Coosemans wrote: > On 16-09-2012 01:27, Eitan Adler wrote: >> On 15 September 2012 17:20, Bruce Cran wrote: >>> On 15/09/2012 21:57, Tijl Coosemans wrote: >>>> >>>> Freeing memory right before exiting is a waste of time. The tool shouldn't >>>> complain about it. >> >> Perhaps, but tools do. This has already been brought up on cfe-dev. >> >>> "/Stop wasting time and just exit already/." - >>> http://blogs.msdn.com/b/oldnewthing/archive/2012/01/05/10253268.aspx >> >> I read this blog post when it came out. :) > > In this case the free is actually wrong, because the pointer can point > to memory allocated by getmntinfo(3) and that manpage says an application > cannot free it. Ah, I missed that. I wish this point was brought up earlier. I'll revert the commit -- Eitan Adler Source & Ports committer X11, Bugbusting teams