Date: Sun, 16 Sep 2012 12:05:41 -0400 From: Eitan Adler <eadler@freebsd.org> To: Tijl Coosemans <tijl@coosemans.org> Cc: Bruce Cran <bruce@cran.org.uk>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240527 - head/bin/df Message-ID: <CAF6rxgnFw9Z0AgjNA8yB2ex4TKCCB4k%2BAkFegopoYFgXt7czTQ@mail.gmail.com> In-Reply-To: <5055E121.2030208@coosemans.org> References: <201209142347.q8ENlN7N034951@svn.freebsd.org> <5054EBCB.6070105@coosemans.org> <5054F116.8090503@cran.org.uk> <CAF6rxgmDckK6RE=UG8dpMDuXk_zPeUTLbC4x74XYK9cJJiYfog@mail.gmail.com> <5055E121.2030208@coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16 September 2012 10:24, Tijl Coosemans <tijl@coosemans.org> wrote: > On 16-09-2012 01:27, Eitan Adler wrote: >> On 15 September 2012 17:20, Bruce Cran <bruce@cran.org.uk> wrote: >>> On 15/09/2012 21:57, Tijl Coosemans wrote: >>>> >>>> Freeing memory right before exiting is a waste of time. The tool shouldn't >>>> complain about it. >> >> Perhaps, but tools do. This has already been brought up on cfe-dev. >> >>> "/Stop wasting time and just exit already/." - >>> http://blogs.msdn.com/b/oldnewthing/archive/2012/01/05/10253268.aspx >> >> I read this blog post when it came out. :) > > In this case the free is actually wrong, because the pointer can point > to memory allocated by getmntinfo(3) and that manpage says an application > cannot free it. Ah, I missed that. I wish this point was brought up earlier. I'll revert the commit -- Eitan Adler Source & Ports committer X11, Bugbusting teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnFw9Z0AgjNA8yB2ex4TKCCB4k%2BAkFegopoYFgXt7czTQ>