From owner-svn-src-all@freebsd.org Wed May 24 21:08:27 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90B0AD7C512; Wed, 24 May 2017 21:08:27 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BE1B1B3D; Wed, 24 May 2017 21:08:27 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x244.google.com with SMTP id u26so34587908pfd.2; Wed, 24 May 2017 14:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=tsG1TSiRKkxSvvT1JDbkdhop+oJyZgeP6OxK//dZxiU=; b=Yk3M+ChvVl8+SlF5yve0Hal6Gzq6ofdNtMbIDWVAa6mDOOAkniAK45xwpBX0kh459f pWA2IDUYqcPkziok5H2RF8ETS/hdXa2GU5+cZd0oIPL2yGPou4zgING02mL5vXMUWFvb lKnaKDsbbUaxuI1mjxEOOi6oWSRo2hX193FqDJ4MqU1OI6nLkuJi56LBhjMA02s6J04F 6QOSJniwJQFaQigr9mgH+kxcqWrFO2Kawe1b0MOrSQKJlpPU0SJR41UuaxMu8z6/rsGs AgkITy0wuA80MQMck3dupvVWz7BEZ9ud7za8Fe3/WzxiaFNGmtisJED/YRqj4hhmUJ8P lw4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=tsG1TSiRKkxSvvT1JDbkdhop+oJyZgeP6OxK//dZxiU=; b=FL7iQjRVoNVynUS1HHgN1PThQInQ+0ScoFb+VSVrtgB+VUA3aE8qD1OR9Lfay6W5z5 gXDF9HBaaCNPWqB+A6pADX5rnrT20mkLVV78LCiI+LtyG0X6lLIWg6MTxDQMFgPfM+AZ 97vOgMDs/MwDenk22koKvf6MmcGGZ6gh0JWKzudCtCv5ogEOOLCvW9ab+xQJIKioiRNp sHPW38F/OWGaSJmVdMly029/WSxu92fZI4KhYcO5m96btp6dmydOkZa1nbFyxkQAD9eA NvmbW95brBhupwq75jxht7nTy4ClOmRbWZiPYawdwBQ2NsT38VGOr5IMlbyHmTr0YWa0 olLA== X-Gm-Message-State: AODbwcA4OhVU+8ThQ0kbiaH8VJU6nQEux1H43PoAG4YJubOYyb+hC0km Uc3gScHO4x2uVGknGQ8= X-Received: by 10.84.194.34 with SMTP id g31mr8257455pld.89.1495660106472; Wed, 24 May 2017 14:08:26 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id r73sm8680488pfk.114.2017.05.24.14.08.25 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 24 May 2017 14:08:25 -0700 (PDT) Subject: Re: svn commit: r318736 - in head: cddl/lib/libzfs contrib/compiler-rt/lib/sanitizer_common contrib/openbsm/libbsm include lib/libarchive lib/libc/gen lib/libc/include lib/libc/sys lib/libkvm lib/libmi... Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_D41F78AE-185C-4C04-A79F-65D75918BEC6"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Wed, 24 May 2017 14:08:24 -0700 Cc: Pedro Giffuni , Konstantin Belousov , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: References: <201705230929.v4N9T5g1028124@repo.freebsd.org> To: Ed Maste X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2017 21:08:27 -0000 --Apple-Mail=_D41F78AE-185C-4C04-A79F-65D75918BEC6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 24, 2017, at 09:26, Ed Maste wrote: >=20 > On 24 May 2017 at 10:53, Pedro Giffuni wrote: >>=20 >> There is now a bunch of coverity issues (OVERFLOW_BEFORE_WIDEN = mostly) >> tied to ino64_t. At least the following CIDs are related: >=20 > On a quick look the OVERFLOW_BEFORE_WIDEN issues are false positives > in practice: for correct operation the product must fit within 32 > bits, because inodes were previously 32 bits. However, it does seem > unusual to perform a multiplication with types that could overflow 32 > bits, and then store the result in a 64-bit variable. So it seems that > a code change to eliminate the warning is likely reasonable. Wouldn=E2=80=99t the proper fix be: - Check the inode value for overflow? - Cast to the smaller historical value? Or: - Widen the type for the smaller historical value to a larger value? Thanks, -Ngie PS I=E2=80=99d have to see how we fixed this internally at Isilon. We = might have a patch kicking around for this. --Apple-Mail=_D41F78AE-185C-4C04-A79F-65D75918BEC6 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZJfZIAAoJEPWDqSZpMIYV7WsQAKz+vRLrXUUO8eWBRebNOBv6 YBhGZpNNUdWdS++LaOJONt/zKT+ShvtgDWCtosQ7U0Kx1N/ePnQfhSUrWIGSPvMK dBNpa80oScDvU24aEBaw+lOpfImKWgxkKK8Bd5QSjzorY9PPe6pde9kypr8RduCQ MPbC4a9rn4PLYqWdMJWFeWii8oonQToOo6Jlv5SdorkcpSp8KfkP1wfrgcorsS25 +ef29047NMG91Fj5PmLf9tc5znTuBap059ZAohvbVwP5BheJ4bntx36a3FDPacxf sOhshfEi+RuR1lDdOh/VP59Ek8Kt//1k0sNPemc7DnG+4OnISBm+nBUd3VIB/2cU r7q19CeU0rwBIjTygSuaE8G0vdQrTXb660l7BT5X02NK4Cgzw24NR1USmau1FkUt FXLbGEMu+wOS2nElHuaZ4PnRSuImPIpvIVbs+2lgCX6YWavPRVJn/5Jaxy+3MiHl zRqKc+PDpo1H0rIZ2qkAFd+uRdcVkp63lUP9ZGlqaDe2ikxW4VhU004Ul7sf9tVN 11nMCx1clGTh3B99R480iByuGiHS3eJmTAmxxwY9zJH61I4k1QW8n77YVIhYCwUN LQi8N3gz9GocX8VjhbfT5XiIFfFn8pX1DtNNy+GmbeBJcIv88xs7aFN9uTuwvY1K Di0zg1Cv8fpv+5q7O//y =9lgE -----END PGP SIGNATURE----- --Apple-Mail=_D41F78AE-185C-4C04-A79F-65D75918BEC6--