From owner-svn-src-projects@FreeBSD.ORG Wed Feb 6 17:31:11 2013 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 397832EA; Wed, 6 Feb 2013 17:31:11 +0000 (UTC) (envelope-from bright@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id BA54ACDA; Wed, 6 Feb 2013 17:31:10 +0000 (UTC) Received: from Alfreds-MacBook-Pro-9.local (c-67-180-208-218.hsd1.ca.comcast.net [67.180.208.218]) by elvis.mu.org (Postfix) with ESMTPSA id 8EFAE1A3C1C; Wed, 6 Feb 2013 09:31:10 -0800 (PST) Message-ID: <5112935E.20508@mu.org> Date: Wed, 06 Feb 2013 09:31:10 -0800 From: Alfred Perlstein User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Eitan Adler Subject: Re: svn commit: r246380 - projects/cider/usr.bin/make References: <201302060436.r164awc3073100@svn.freebsd.org> <51125D8C.3050405@mu.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-projects@freebsd.org, Alfred Perlstein , src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2013 17:31:11 -0000 On 2/6/13 6:01 AM, Eitan Adler wrote: > On 6 February 2013 08:41, Alfred Perlstein wrote: >> On 2/5/13 8:40 PM, Eitan Adler wrote: >>> On 5 February 2013 23:36, Alfred Perlstein wrote: >>>> Author: alfred >>>> Date: Wed Feb 6 04:36:57 2013 >>>> New Revision: 246380 >>>> URL: http://svnweb.freebsd.org/changeset/base/246380 >>>> >>>> Log: >>>> Add headers needed to compile on OS X 10.7.5. >>> Please make sure to annotate that these headers are required on >>> !FreeBSD otherwise they may be removed if someone does a "include what >>> you use" run. >>> >>> >> Is there an existing way of doing this? >> >> I'm not sure if I should just do >> #ifndef __FreeBSD__ >> or something else? > This is fine by me, but others may have more clue about what is convention. > > I would like everyone to contribute how they can to this branch. If you have access to OS X, please do check it out and add these fences to prevent these issues. -Alfred