From owner-freebsd-current@freebsd.org Sun Dec 29 00:32:42 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F3E3B1CD3C6 for ; Sun, 29 Dec 2019 00:32:41 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670043.outbound.protection.outlook.com [40.107.67.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47lhNS4brCz3Qct for ; Sun, 29 Dec 2019 00:32:40 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QskNRd1NHMj/VkqWLp9+adiuw4694JnE8agQpH7YKpfQIDAk31r+OYJ+EDkKZOYJXpRfgLvrMFXMSwrUVZMM8mZNk95n01ZKs0nzIBd1jZ6DdElX5FI0yXdhOEVvviMY67sY94cZGv4ef6dt/Faayq4Nkcq18HEKUWeHy4W1jCcDJHovHq8pH6U8WviOXaN+C6Im4B1gMlRQzJ6G70Dsxl/lN16co4h+cbbfOmuOkZssWv5w5JR94Nb2O0528VII8GAYLja3VfEiisek7ADjIMibb2fTbvX2RhYPxggiPfNrl/pmjYO2gfjb1WZA4fYjUZ2rHuSF9Xc2kSVuOcjjVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oz/Bgw0EL1E7xYKQ75OH6pSdUJgsYfoyYVBWb/0qXi8=; b=QYNRc1nYwBq/bTfwZsuaZHcFH1aSM4dRx9MJDBvhUfkmRySTe1donzXiYtaebUcQWv6nkuKzac6x0qrwVY6/FMH9TdCMM1RU2WyXUHFuiw0mNFh1lvtlNmFxLHs8YgUT40+1baqQq2xrfb9UuSgU05XMMv5AW8CjEp93H2NbSLydDcwKvL7QFC0jP9aZ08oF9kGntunGKmLwMUGRf4tfl/x6kQup+a6Uzy/m8BDxW9cc0hbClF0g5Oeygisc/gYvy8uzYnd/fnpsrBDfZAPc78YT+g9t8zUbzpzktRXEk3etIjwLmxhkSx8LEBT+v0QcAFRhMVL7dVExqQr/xArtVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM (52.132.69.153) by YQBPR0101MB1745.CANPRD01.PROD.OUTLOOK.COM (52.132.71.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2581.11; Sun, 29 Dec 2019 00:32:39 +0000 Received: from YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM ([fe80::7512:8580:8d82:6c94]) by YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM ([fe80::7512:8580:8d82:6c94%6]) with mapi id 15.20.2581.007; Sun, 29 Dec 2019 00:32:39 +0000 From: Rick Macklem To: "freebsd-current@freebsd.org" Subject: Re: getting rid of sys/nfs/nfs_lock.c Thread-Topic: getting rid of sys/nfs/nfs_lock.c Thread-Index: AQHVvd4uYot+uGDYskWjg23o3Tr07KfQQvDH Date: Sun, 29 Dec 2019 00:32:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87e00d51-2aa7-4dba-ebcc-08d78bf69c0e x-ms-traffictypediagnostic: YQBPR0101MB1745: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0266491E90 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(396003)(136003)(39860400002)(189003)(199004)(786003)(8936002)(52536014)(5660300002)(186003)(316002)(55016002)(33656002)(9686003)(53546011)(6506007)(71200400001)(7696005)(2940100002)(64756008)(66556008)(6916009)(86362001)(966005)(81166006)(66446008)(76116006)(8676002)(66476007)(66946007)(81156014)(478600001)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:YQBPR0101MB1745; H:YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C2h2VBDR5P6h/6AKAw7VV3S1EUgwcmkHLdjZjaPfrODgCH9x3Ix69G0vcMgQkV4kPs7fNpLMBK8wiq5peCvfdoJPPoduwjOl3LAxzJVdT4l2eQuyWLtWRvI8yuRlRLPDiXiNSBwG2SkkW2wHl6g6hf2qGkPIVWv2pf/2Gmlufo/HDviooqjnMRiUeVXdc01fj8TLIcsmMxoblo7aX/XdNK4wiiQPAeI16pZ48/vzyVt7RXREiyJO0rqlYNVELgnlG9xpR4jk4mXkLrAVOapbE76qo0+wHjWSMCgDO3m/52os8C/02kHOtPk8Y/V/1KriFBmS1RsZl/YJFiNdZHQFk3btyzOirB4uaoRVDvvThi+Z8w4O5TpA0Pwhene3lDdJK8zK3FZYvacVGH3xusAjt1f9knIHRaZKxJxRsqKizbN71CrxCSdDd3LHaw8WdF6scAEbJaBobY6NgM9Aod/QAL2MsE+LnGrKP5d/vx5au+4= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 87e00d51-2aa7-4dba-ebcc-08d78bf69c0e X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2019 00:32:39.2014 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gfQUQZFI7zGlEYGODJty/YOYhokI2g1qKqsB5CQ5KiB1531Vx/fbHYRIjGh8U+YPdzRX8sYFJdL3tAJMJ7Xiqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB1745 X-Rspamd-Queue-Id: 47lhNS4brCz3Qct X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.43 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.67 / 15.00]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.37)[ipnet: 40.64.0.0/10(-3.84), asn: 8075(-2.94), country: US(-0.05)]; RCVD_IN_DNSWL_NONE(0.00)[43.67.107.40.list.dnswl.org : 127.0.3.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 00:32:42 -0000 Oh, I forgot to mention that, post March 2008, this code was replaced by th= e in kernel nlm found in sys/nlm, which is why it has been in use. ________________________________________ From: owner-freebsd-current@freebsd.org = on behalf of Rick Macklem Sent: Saturday, December 28, 2019 7:30 PM To: freebsd-current@freebsd.org Subject: getting rid of sys/nfs/nfs_lock.c Hi, sys/nfs/nfs_lock.c uses Giant. Since it has not been used by default since March 2008, I suspect it can be removed from head without any impact. Post March 2008, the only way this code could be executed is by both building a kernel without "options NFSLOCKD" and deleting nfslockd.ko from the kernel boot directory and then running rpc.lockd on the system. I doubt anyone has been doing both of the above, but if you think it is still useful, please speak up. (I have an untested patch that replaces Gian= t with a regular mutex. I realized this code is not used when I trying to tes= t it.;-) Also, if it seems appropriate, I could commit a patch that makes it print o= ut "deprecated and going away before FreeBSD 13" message, but I doubt anyone will ever see it. Should I do such a message and wait a few months for the deletion? Thanks for your comments, rick ps: The current patch that prepares the kernel for deletion of sys/nfs/nfs_= lock.c is in reviews.freebsd.org/D22933. _______________________________________________ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"