From nobody Fri Feb 13 12:35:04 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fCBT43YL3z6Rgwt for ; Fri, 13 Feb 2026 12:35:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fCBT42dNkz46h0 for ; Fri, 13 Feb 2026 12:35:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770986104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6LtL1CBNxOOQee9bR9gbkZLnRAmbn0NQVkpBDkja6LY=; b=o7VYhYRgIWTFEMDB+TE5jP0QLCzS3IgVTk3zAM3ZTwRmgY2/2jYkByNi/rp+b3n5y5BA3X lTEYSWt09Ma5xFP4c6VKrBpqxeT94KezepQSxXJBcLgdzEjgImsfM8tTlXcFplY9hIbHGd qrcGuD2CeJCMICpI/wOcUuMnjhvcHl5F23bwkPwS9xKEmLSErqQQRkNoVfcCeH2zH6KXHd HzH+NttmIWw+tE36Su1kVxrTBoA60WpJLMdf3Mj94XiupVMphbfjD6o3loW9ZGWQoCA3WP NgFRlOPo2QO0AvoRoH/kV1Y/jzLSErUpETSl1Yw1GxwfwM522290xhu/wBBBWg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770986104; a=rsa-sha256; cv=none; b=i/0ECKipQPthkyQjQq1AyDVoAqKDBMs9FK4C4eBjV5q6m9oxVUWGbLEGa9tK2id4t7eMMt 1HnsCKcxP++x5FD1ondxehosFGR+MAV9fRXu9vLS9YQX+n3/BZC3ytcxQyomLV8Pd26YSt pKn2IOxAISM9oSD08PwrJGSj7OYdOfMZk2gbbPy6PrqV3qaiq1dvoLXxTz/VI8QcnzNous 8155N+ZcaZLyamqItHPpJ9CsMHIiYqZqj0UP9flVQZFbeEONZimIJj0bYV7h3u/R23Ikvx uTmJ7GE+/kMb+S2kXSd6LaEwbNuyEDRCu9mxE92DHvkEcU1Q9oeopHj4U9zbYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770986104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6LtL1CBNxOOQee9bR9gbkZLnRAmbn0NQVkpBDkja6LY=; b=MbbCD8TZG8g8ZlfbxQ8vnHcXTviSH3eJC/4YuHh2BdJTCZs/pJOoyQOLSNDWrQ5wYcV2CM d96rfDVGZk/bilnb1eUlgh1o8hMeYTaxReclNHVFh9R6wdNO7CSi9fTZvfPXM4UR2thmMX OVUgATRGzOcrAUiFYig4VJRNg1lhAWxLKP3hHJ+Wkk2VKXnmrIi100kt4aaMfEquDCHFu9 4UHup/k9r5EGSk05VdamwFRL7QNvniWYnLiNMkKXzXkwVL1ocI2OPYn/r1KUg0Lkiv+IdG zRh25PrrhHJC3VZkRFjca3RZWmTyvdClZd4WFZEQiywnpqWJzYm6q0R7QDwBEA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fCBT42B63z64Z for ; Fri, 13 Feb 2026 12:35:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3140e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 13 Feb 2026 12:35:04 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 1e2eea55c455 - main - nvme: Change fail_on_reset to bool List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1e2eea55c4559544b68c99e95641097983230611 Auto-Submitted: auto-generated Date: Fri, 13 Feb 2026 12:35:04 +0000 Message-Id: <698f1a78.3140e.725b9d85@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=1e2eea55c4559544b68c99e95641097983230611 commit 1e2eea55c4559544b68c99e95641097983230611 Author: Dag-Erling Smørgrav AuthorDate: 2026-02-13 12:34:42 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-13 12:34:51 +0000 nvme: Change fail_on_reset to bool This is safe since sysctl_handle_bool() handles ints transparently. Sponsored by: Klara, Inc. Sponsored by: NetApp, Inc. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D55263 --- sys/dev/nvme/nvme_private.h | 2 +- sys/dev/nvme/nvme_sysctl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/nvme/nvme_private.h b/sys/dev/nvme/nvme_private.h index 96ab5cc553e3..d06862ba5f4a 100644 --- a/sys/dev/nvme/nvme_private.h +++ b/sys/dev/nvme/nvme_private.h @@ -300,8 +300,8 @@ struct nvme_controller { struct nvme_async_event_request aer[NVME_MAX_ASYNC_EVENTS]; uint32_t is_resetting; - u_int fail_on_reset; + bool fail_on_reset; bool is_failed; bool is_failed_admin; bool is_dying; diff --git a/sys/dev/nvme/nvme_sysctl.c b/sys/dev/nvme/nvme_sysctl.c index 50d19e730a16..1b64ebddb9b2 100644 --- a/sys/dev/nvme/nvme_sysctl.c +++ b/sys/dev/nvme/nvme_sysctl.c @@ -425,7 +425,7 @@ nvme_sysctl_initialize_ctrlr(struct nvme_controller *ctrlr) CTLFLAG_RD, &ctrlr->cap_hi, 0, "Hi 32-bits of capacities for the drive"); - SYSCTL_ADD_UINT(ctrlr_ctx, ctrlr_list, OID_AUTO, "fail_on_reset", + SYSCTL_ADD_BOOL(ctrlr_ctx, ctrlr_list, OID_AUTO, "fail_on_reset", CTLFLAG_RD, &ctrlr->fail_on_reset, 0, "Pretend the next reset fails and fail the controller");