From owner-svn-src-head@FreeBSD.ORG Mon Aug 25 16:08:56 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 344A155A; Mon, 25 Aug 2014 16:08:56 +0000 (UTC) Received: from mail-qg0-x236.google.com (mail-qg0-x236.google.com [IPv6:2607:f8b0:400d:c04::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B5FB43B81; Mon, 25 Aug 2014 16:08:55 +0000 (UTC) Received: by mail-qg0-f54.google.com with SMTP id j5so10307270qga.41 for ; Mon, 25 Aug 2014 09:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=vETWfzMVepueI7KZI2trHgboCVBZivu1KPyagjq+I8E=; b=yicXPft+lrcLVxRp0vrs1FkM1GpaXexI3Gvk/iNKPCRcWmZXUD48x38k/CQRRWqTtE aq6KwVjI8p12YPfr7CArg4Cq/9/RK7R/zkqp2f0jGkz1L6TaA7RUpYJQMsqypH1CA2Li USRLP7IbGjxRmFdvtEFwp/sVxj1pek7nH3K2I8D4/LN94yTiNWEV8YK1AbvJXNT9XY4R o4ooSHZuo6lmRuUHsCqwCWoO57fL6tRQO9mLtrSagi0guqKVfwfBDro4e4CM0guWCLmj RVtOJJ01E1WtWrQWibhY36R/Wy9AFeq5Q4EntKXuh7vPT/Xka0Y1JIixSAnt3/hNIa8O D2gw== MIME-Version: 1.0 X-Received: by 10.140.19.201 with SMTP id 67mr34226609qgh.28.1408982934788; Mon, 25 Aug 2014 09:08:54 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.39.139 with HTTP; Mon, 25 Aug 2014 09:08:54 -0700 (PDT) In-Reply-To: <2177184.NMfUXrE71G@ralph.baldwin.cx> References: <201408250503.s7P53Axo057720@svn.freebsd.org> <2177184.NMfUXrE71G@ralph.baldwin.cx> Date: Mon, 25 Aug 2014 09:08:54 -0700 X-Google-Sender-Auth: EkfBQp7SYcG37TtQCa4yht37CW4 Message-ID: Subject: Re: svn commit: r270516 - head/sys/dev/drm2/i915 From: Adrian Chadd To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Aug 2014 16:08:56 -0000 On 25 August 2014 07:26, John Baldwin wrote: > On Monday, August 25, 2014 05:03:10 AM Adrian Chadd wrote: >> Author: adrian >> Date: Mon Aug 25 05:03:10 2014 >> New Revision: 270516 >> URL: http://svnweb.freebsd.org/changeset/base/270516 >> >> Log: >> i915 driver - enable opregion handle; program CADL. >> >> add opregion handling for drm2 - which exposes some ACPI video >> configuration pieces that some Lenovo laptop models use to flesh out which >> video device to speak to. This enables the brightness control in ACPI to >> work these models. >> >> The CADL bits are also important - it's used to figure out which ACPI >> events to hook the brightness buttons into. It doesn't yet seem to work >> for me, but it does for the OP. > > We should also look at enabling the opregion notification stuff. Presumably > that is part of ACPI-CA itself so it shouldn't be hard to make the equivalent > calls for FreeBSD. I agree. Like this was - patches gratefully accepted. :) > Also, is leaving around the #if 0'd Linux version something the drm2 code does > in general or was that unique to this patch? If the latter, we should remove > the duplicate #if 0 code (list_for_each, etc.) Sometimes it is, sometimes it isn't. -a