From owner-freebsd-net@FreeBSD.ORG  Sat Dec 18 12:28:16 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D3F0A106566C
	for <freebsd-net@freebsd.org>; Sat, 18 Dec 2010 12:28:16 +0000 (UTC)
	(envelope-from shteryana@gmail.com)
Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com
	[209.85.216.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 835438FC12
	for <freebsd-net@freebsd.org>; Sat, 18 Dec 2010 12:28:16 +0000 (UTC)
Received: by qwj9 with SMTP id 9so1435290qwj.13
	for <freebsd-net@freebsd.org>; Sat, 18 Dec 2010 04:28:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:sender:reply-to:received
	:in-reply-to:references:date:x-google-sender-auth:message-id:subject
	:from:to:cc:content-type;
	bh=EwpBdLxp3rBaLlWJV0im5V5fxUdR/m7RMQ8/iQHepj4=;
	b=shL+lFkpuBkI72QwVYc19uF/KShp11nZfnZgSjrT2ro84MmdUdsa8PMwx6K5ExNkUg
	OQiEFIaBZ2p3rUYgq6KLm+OemHac9fl3pCJ9SlUAW431mlkrzln8re7VQUGdRFJpPMpu
	6KckwYH+MRopcwoAsQ//mOzuH6EQTbIPPpq+s=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:reply-to:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	b=RoxF9hLIljZHFlJhOqJ/3hIFZ+63HasQxmq1Rcl20eYnckawK5rjkyyJuDZ8cJQChY
	r+1dIdGSXmOBVa/LA6CE8WuEhp+bjE9Ck7/Wimq4bvV7mzgXXSDvK20xtC6zW5z9aQbM
	83cXjvnmQY1xXFHVQT7JValZr6zZxn415+pr0=
MIME-Version: 1.0
Received: by 10.229.224.79 with SMTP id in15mr1760358qcb.279.1292673712219;
	Sat, 18 Dec 2010 04:01:52 -0800 (PST)
Sender: shteryana@gmail.com
Received: by 10.229.91.14 with HTTP; Sat, 18 Dec 2010 04:01:52 -0800 (PST)
In-Reply-To: <20101218110358.GY33073@deviant.kiev.zoral.com.ua>
References: <86wrn7gxvd.fsf@kopusha.home.net>
	<20101218110358.GY33073@deviant.kiev.zoral.com.ua>
Date: Sat, 18 Dec 2010 14:01:52 +0200
X-Google-Sender-Auth: TYljNvS7iLKIHzFOhVwYYVj0s5I
Message-ID: <AANLkTimBd74+0ycDN9p8A4Lt5myq8po7uXCZua1PGdTS@mail.gmail.com>
From: Shteryana Shopova <syrinx@FreeBSD.org>
To: Kostik Belousov <kostikbel@gmail.com>
Content-Type: text/plain; charset=UTF-8
Cc: freebsd-net@freebsd.org, Mikolaj Golub <to.my.trociny@gmail.com>
Subject: Re: bsnmp/snmpmod.h: #include <sys/queue.h> is missed
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: syrinx@FreeBSD.org
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Dec 2010 12:28:16 -0000

On Sat, Dec 18, 2010 at 1:03 PM, Kostik Belousov <kostikbel@gmail.com> wrote:
> On Sat, Dec 18, 2010 at 12:48:38PM +0200, Mikolaj Golub wrote:
>> Hi,
>>
>> bsnmp/snmpmod.h uses SLIST but does not includes <sys/queue.h>. This breaks
>> net-mgmt/bsnmp-ucd port (ports/153153).
>>
>> Could somebody look at the attached patch?
>
> <sys/types.h>, as well as <sys/param.h> should be included before
> other headers.
>

And the explicit includes of those files should be removed from the
sources of the bsnmpd(1) modules, I think. I will put this in SVN
along with a couple of other patches I have for bsnmp in my queue.
Sorry for not being able to reply sooner after this problem was
reported. Also, the bsnmptools port should be marked as obsolete as
the tools are now in head.

cheers,
Shteryana