From owner-svn-src-all@freebsd.org Wed Jul 13 18:47:30 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3AE0B98B21; Wed, 13 Jul 2016 18:47:30 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-it0-x234.google.com (mail-it0-x234.google.com [IPv6:2607:f8b0:4001:c0b::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7CF111632; Wed, 13 Jul 2016 18:47:30 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-it0-x234.google.com with SMTP id u186so28744509ita.0; Wed, 13 Jul 2016 11:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=RaGF21AB1QWoIX3QgdZjgbRsuIgavUw0ghXsLHbi7tA=; b=y7HcIXqel4RNTf5UXuCXva/XC8QjO0EcLRkVaB+h1vwjlg/xV+x6tR6OEMu5XGIU/F weP4l1AsSjFx/EQ+t2CAkalYghiYhedA4NhA4QtGhqwTT+8w+nIncLkrKs/D/FVN55BP psk+OjxX+WNh/WFGDgEGHCwN+ZgX0QK+Y4IkwPKaxsHeHDk0W4ix6h0Hcaunhz3sTIK9 wncweLAmf6iMB4I2dMEbka2bvm5eJdgfYCzQd3xtZrRrcEKE/pkzXNT4BsxJizybLv7w 34s70eBv6LbjxJQNglzneTHdtUoELOj64swVIo18yxiyJiCDSQ4vTp5OUYsJVPUKOYut iFHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=RaGF21AB1QWoIX3QgdZjgbRsuIgavUw0ghXsLHbi7tA=; b=SIOdvesfrD/T7s7QZBePaDBsMl6cohurKk/MJMXghIZ+VBbJJzPn6iih9tqVyqKmNi D4N7MMJe+N871f6Xe7JmozQO+snEcpyGDAzj2tBADDk+3NB2vDK+WBVJiFgjVauMiDYr b1pNXNsMu4fS8Xk3vidz6aqnbwauqZ8Aq6NEm4bRzmXWA2JXGqHC2tAptbloVTBd22Gg Gxo4odRaznUlAw8ae3ombQahL6STKQ1E/PydYk7WBKCcmjXro1Q+973rWqGhZ1H5stat wytcVVrEkNFxo7xDvo4WRQ2KjqXGy/eMp8MUCcmSTiBYR2Z9o4jyEECUbJPrA5oOAtwf 8Aeg== X-Gm-Message-State: ALyK8tLTvKsSsFd5uviBYBEqW7oF/q+Zw+9nDx5+S/WIfvGnOfP9sJ8gbomhnML4JFNnm4mHhor5AOBySjUKtA== X-Received: by 10.36.200.131 with SMTP id w125mr10061126itf.80.1468435649627; Wed, 13 Jul 2016 11:47:29 -0700 (PDT) MIME-Version: 1.0 Sender: adrian.chadd@gmail.com Received: by 10.36.141.129 with HTTP; Wed, 13 Jul 2016 11:47:28 -0700 (PDT) In-Reply-To: <578669BC.1010202@FreeBSD.org> References: <201409090418.s894IKMT007235@svn.freebsd.org> <578669BC.1010202@FreeBSD.org> From: Adrian Chadd Date: Wed, 13 Jul 2016 11:47:28 -0700 X-Google-Sender-Auth: tQ1HurMw1ltbDJGm-KRqlNW085k Message-ID: Subject: Re: svn commit: r271300 - in head/sys: net netinet To: "Andrey V. Elsukov" Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2016 18:47:30 -0000 ugh, hm. Wonder how I missed that. I'll go see about fixing it. -adrian On 13 July 2016 at 09:18, Andrey V. Elsukov wrote: > On 09.09.14 08:18, Adrian Chadd wrote: >> Author: adrian >> Date: Tue Sep 9 04:18:20 2014 >> New Revision: 271300 >> URL: http://svnweb.freebsd.org/changeset/base/271300 >> >> Log: >> Update the IPv4 input path to handle reassembled frames and incoming frames >> with no RSS hash. >> >> When doing RSS: >> >> * Create a new IPv4 netisr which expects the frames to have been verified; >> it just directly dispatches to the IPv4 input path. >> * Once IPv4 reassembly is done, re-calculate the RSS hash with the new >> IP and L3 header; then reinject it as appropriate. >> * Update the IPv4 netisr to be a CPU affinity netisr with the RSS hash >> function (rss_soft_m2cpuid) - this will do a software hash if the >> hardware doesn't provide one. >> >> NICs that don't implement hardware RSS hashing will now benefit from RSS >> distribution - it'll inject into the correct destination netisr. >> >> Note: the netisr distribution doesn't work out of the box - netisr doesn't >> query RSS for how many CPUs and the affinity setup. Yes, netisr likely >> shouldn't really be doing CPU stuff anymore and should be "some kind of >> 'thing' that is a workqueue that may or may not have any CPU affinity"; >> that's for a later commit. >> >> Differential Revision: https://reviews.freebsd.org/D527 >> Reviewed by: grehan >> >> Modified: >> head/sys/net/netisr.h >> head/sys/netinet/in_var.h >> head/sys/netinet/ip_input.c >> >> Modified: head/sys/netinet/ip_input.c > > Hi, I am sorry for addressing this old message, but it looks like you > can not use the same IPCTL_XXX constant for several different oids. > > ... >> @@ -266,6 +292,46 @@ SYSCTL_PROC(_net_inet_ip, IPCTL_INTRQDRO > ^^^^ - there >> CTLTYPE_INT|CTLFLAG_RD, 0, 0, sysctl_netinet_intr_queue_drops, "I", >> "Number of packets dropped from the IP input queue"); >> >> +SYSCTL_PROC(_net_inet_ip, IPCTL_INTRQMAXLEN, intr_direct_queue_maxlen, > ^^^ - and there. >> + CTLTYPE_INT|CTLFLAG_RW, 0, 0, sysctl_netinet_intr_direct_queue_maxlen, "I", >> + "Maximum size of the IP direct input queue"); > > User applications use these constants to address specific oids and I > don't think and don't see that the kernel calls several handlers for one > oid. > > -- > WBR, Andrey V. Elsukov >