From owner-freebsd-stable@FreeBSD.ORG Tue Apr 23 13:15:32 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id CE27E8F7 for ; Tue, 23 Apr 2013 13:15:32 +0000 (UTC) (envelope-from tevans.uk@googlemail.com) Received: from mail-la0-x233.google.com (mail-la0-x233.google.com [IPv6:2a00:1450:4010:c03::233]) by mx1.freebsd.org (Postfix) with ESMTP id 58C791133 for ; Tue, 23 Apr 2013 13:15:32 +0000 (UTC) Received: by mail-la0-f51.google.com with SMTP id fh20so533732lab.38 for ; Tue, 23 Apr 2013 06:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=T47PGY7bJfoLMp+F6PrMqREgmZ2FPnTuBcz8TVQFdC0=; b=w57LOUezQMd+kTtCl/CTZsz8ra4zuqFQF6907hJ30zYl999VWFusjLJ8i/Nz6RGNuR H0t1ZZAZeSd/8dHLHl9Q2jSyBFGqxrdKcQxm7mFx/16mlcO3SW1lOZrWgmRYOOOV7Bk9 Z1oHBLDOwFWYX2diDdFuo46l4lxvQchqJUejQP5bdp7nUjEfbuciz7ovX0Lyt03bND3/ 0Av8bZDo4WlLe3jDlPk9Px9qq6G2eBr8l8qo74UREuc/d++u3+QmGIz++nFSy+BgtA4M DniINuy09oP9aFx72dgtWE1Eo4C0j27V5ouQSRoEHKurRr39Axj8czp5dHcx2210bSCZ nFnA== MIME-Version: 1.0 X-Received: by 10.112.173.70 with SMTP id bi6mr15455353lbc.116.1366722931271; Tue, 23 Apr 2013 06:15:31 -0700 (PDT) Received: by 10.112.162.36 with HTTP; Tue, 23 Apr 2013 06:15:31 -0700 (PDT) In-Reply-To: <20130423125144.GA62949@icarus.home.lan> References: <20130422051452.GA2148@icarus.home.lan> <51763BF9.2000506@FreeBSD.org> <20130423092602.GA58831@icarus.home.lan> <51765466.4040209@FreeBSD.org> <4D28DBAE46424C268AA22FCDD8657946@multiplay.co.uk> <20130423114722.GA61919@icarus.home.lan> <20130423125144.GA62949@icarus.home.lan> Date: Tue, 23 Apr 2013 14:15:31 +0100 Message-ID: Subject: Re: ada(4) and ahci(4) quirk printing From: Tom Evans To: Jeremy Chadwick Content-Type: text/plain; charset=UTF-8 Cc: freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2013 13:15:32 -0000 On Tue, Apr 23, 2013 at 1:51 PM, Jeremy Chadwick wrote: > On Tue, Apr 23, 2013 at 01:20:31PM +0100, Steven Hartland wrote: >> >4) camcontrol wouldn't address the need/interest for ahci(4) quirks to >> >be made available. >> >> Why? > > Because camcontrol is for CAM. ahci(4) is not part of CAM. The last > place I'd look for "poking at AHCI" (as in *actual AHCI*) is camcontrol. > > This is one of the reasons sysctl exists -- it's a sort of "covers > everything" tree, on a per-device basis. Just on this point, these quirks aren't actually quirks of ahci(4) are they? They are quirks of the disks that are attached to ahci(4), and presumably should apply regardless of whether the disk in question is hooked up to ahci(4), siis(4) or even mps(4). To my mind, this means the quirks should belong to da(4), or at the very least ada(4). ada(4) and da(4) are both manipulated by CAM, so having this in camcontrol seems logical to me. To clarify, my mind is completely oblivious of how all this is implemented in software, so perhaps my mind needs to be changed rather than the code! Cheers Tom