Date: Wed, 14 Sep 2016 17:04:20 +0800 From: Vanilla Hsu <vanilla@fatpipi.com> To: Mathieu Arnold <mat@freebsd.org> Cc: "Vanilla I. Shu" <vanilla@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r422100 - in head/www: . fabio fabio/files Message-ID: <CAB_qb6_6h4jC4z%2BtEOzbSJCr8M_3OHz3-y6hPhhreE2j%2BKHJqw@mail.gmail.com> In-Reply-To: <8698eae2-29e9-c4f4-1c8e-4ce21afc2b6b@FreeBSD.org> References: <201609140406.u8E46xcm019346@repo.freebsd.org> <8698eae2-29e9-c4f4-1c8e-4ce21afc2b6b@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Got it, thanks for your suggestion.
2016-09-14 14:44 GMT+08:00 Mathieu Arnold <mat@freebsd.org>:
> Le 14/09/2016 =C3=A0 06:06, Vanilla I. Shu a =C3=A9crit :
> > +GH_ACCOUNT=3D eBay:DEFAULT
>
> You can drop the :DEFAULT, it is the, well, default.
>
> > +GH_PROJECT=3D fabio
>
> You can remove this one, it is the default.
> > +USERS=3D nobody
> > +GROUPS=3D nobody
>
> I am pretty sure nothing should belong, or run, as nobody, and you
> should create a user for this. As a side note, this user and group
> already exist on all FreeBSD installations and they do not need to be
> added here.
>
> > +do-build:
> > + @${MKDIR} ${WRKSRC}/src/github.com/eBay/fabio
> > +
> > +.for src in .gitignore .travis.yml CHANGELOG.md Dockerfile LICENSE
> Makefile \
> > + README.md Vagrantfile admin build cert config demo exit fabio.png=
\
> > + fabio.properties listen.go listen_test.go main.go metrics proxy \
> > + registry route routes.txt vendor
> > + @${MV} ${WRKSRC}/${src} \
> > + ${WRKSRC}/src/github.com/eBay/fabio
> > +.endfor
>
> All this, firstly, belong to the extract phase, and can be done better as=
:
>
> GH_SUBDIR=3D src/github.com/eBay/fabio
>
> --
> Mathieu Arnold
>
>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAB_qb6_6h4jC4z%2BtEOzbSJCr8M_3OHz3-y6hPhhreE2j%2BKHJqw>